All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: Large stack usage in fs code (especially for PPC64)
Date: Tue, 18 Nov 2008 04:53:05 -0500	[thread overview]
Message-ID: <20081118095305.GA24119@infradead.org> (raw)
In-Reply-To: <1226963005.7178.248.camel@pasglop>

On Tue, Nov 18, 2008 at 10:03:25AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2008-11-17 at 15:34 -0500, Steven Rostedt wrote:
> > Note, I was using a default config that had CONFIG_IRQSTACKS off and
> > CONFIG_PPC_64K_PAGES on.
> 
> For one, we definitely need to turn IRQSTACKS on by default ... In fact,
> I'm pondering just removing the option.

It shouldn't be a user-visible option.  It shouldn't on x86 either, but
there it always gets into the ideological 4k stacks flameware so people
usually gave up after a while instead of doing the sensibke 8k +
irqstacks by default, 4k as an option..

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@ozlabs.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Large stack usage in fs code (especially for PPC64)
Date: Tue, 18 Nov 2008 04:53:05 -0500	[thread overview]
Message-ID: <20081118095305.GA24119@infradead.org> (raw)
In-Reply-To: <1226963005.7178.248.camel@pasglop>

On Tue, Nov 18, 2008 at 10:03:25AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2008-11-17 at 15:34 -0500, Steven Rostedt wrote:
> > Note, I was using a default config that had CONFIG_IRQSTACKS off and
> > CONFIG_PPC_64K_PAGES on.
> 
> For one, we definitely need to turn IRQSTACKS on by default ... In fact,
> I'm pondering just removing the option.

It shouldn't be a user-visible option.  It shouldn't on x86 either, but
there it always gets into the ideological 4k stacks flameware so people
usually gave up after a while instead of doing the sensibke 8k +
irqstacks by default, 4k as an option..


  reply	other threads:[~2008-11-18  9:53 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17 20:34 Large stack usage in fs code (especially for PPC64) Steven Rostedt
2008-11-17 20:34 ` Steven Rostedt
2008-11-17 20:59 ` Steven Rostedt
2008-11-17 20:59   ` Steven Rostedt
2008-11-17 21:18   ` Linus Torvalds
2008-11-17 21:18     ` Linus Torvalds
2008-11-17 21:25     ` Pekka Enberg
2008-11-17 21:25       ` Pekka Enberg
2008-11-18  0:54     ` Steven Rostedt
2008-11-18  0:54       ` Steven Rostedt
2008-11-18  1:05       ` Paul Mackerras
2008-11-18  1:05         ` Paul Mackerras
2008-11-18  1:41         ` Steven Rostedt
2008-11-18  1:41           ` Steven Rostedt
2008-11-18  2:01           ` Steven Rostedt
2008-11-18  2:01             ` Steven Rostedt
2008-11-17 22:16   ` Paul Mackerras
2008-11-17 22:16     ` Paul Mackerras
2008-11-17 23:30     ` Steven Rostedt
2008-11-17 23:30       ` Steven Rostedt
2008-11-17 23:04   ` Benjamin Herrenschmidt
2008-11-17 23:04     ` Benjamin Herrenschmidt
2008-11-18  2:29   ` Steven Rostedt
2008-11-18  2:29     ` Steven Rostedt
2008-11-18  2:36     ` Paul Mackerras
2008-11-18  2:36       ` Paul Mackerras
2008-11-18  5:40       ` David Miller
2008-11-18  5:40         ` David Miller
2008-11-17 21:08 ` Andrew Morton
2008-11-17 21:08   ` Andrew Morton
2008-11-17 21:08   ` Andrew Morton
2008-11-17 21:23   ` Linus Torvalds
2008-11-17 21:23     ` Linus Torvalds
2008-11-17 21:23     ` Linus Torvalds
2008-11-17 21:31     ` Andrew Morton
2008-11-17 21:31       ` Andrew Morton
2008-11-17 21:31       ` Andrew Morton
2008-11-17 21:42       ` Linus Torvalds
2008-11-17 21:42         ` Linus Torvalds
2008-11-17 21:42         ` Linus Torvalds
2008-11-17 23:17       ` Benjamin Herrenschmidt
2008-11-17 23:17         ` Benjamin Herrenschmidt
2008-11-17 23:17         ` Benjamin Herrenschmidt
2008-11-17 21:09 ` Linus Torvalds
2008-11-17 21:09   ` Linus Torvalds
2008-11-17 22:53   ` Paul Mackerras
2008-11-17 22:53     ` Paul Mackerras
2008-11-18 10:07     ` Nick Piggin
2008-11-18 10:07       ` Nick Piggin
2008-11-17 23:13   ` Benjamin Herrenschmidt
2008-11-17 23:13     ` Benjamin Herrenschmidt
2008-11-17 23:22     ` Josh Boyer
2008-11-17 23:22       ` Josh Boyer
2008-11-17 23:28     ` Linus Torvalds
2008-11-17 23:28       ` Linus Torvalds
2008-11-18  0:11       ` Paul Mackerras
2008-11-18  0:11         ` Paul Mackerras
2008-11-18  2:08         ` Linus Torvalds
2008-11-18  2:08           ` Linus Torvalds
2008-11-18 10:24           ` Nick Piggin
2008-11-18 10:24             ` Nick Piggin
2008-11-18 11:44             ` Paul Mackerras
2008-11-18 11:44               ` Paul Mackerras
2008-11-18 16:02             ` Linus Torvalds
2008-11-18 16:02               ` Linus Torvalds
2008-11-18  7:25       ` Benjamin Herrenschmidt
2008-11-18  7:25         ` Benjamin Herrenschmidt
2008-11-17 23:03 ` Benjamin Herrenschmidt
2008-11-17 23:03   ` Benjamin Herrenschmidt
2008-11-18  9:53   ` Christoph Hellwig [this message]
2008-11-18  9:53     ` Christoph Hellwig
2008-11-18 10:37     ` Ingo Molnar
2008-11-18 10:37       ` Ingo Molnar
2008-11-17 23:30 ` Benjamin Herrenschmidt
2008-11-17 23:30   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081118095305.GA24119@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.