From: David Brownell <david-b@pacbell.net>
To: avorontsov@ru.mvista.com
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Li Yang <leoli@freescale.com>,
linux-usb@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6 v2] usb/fsl_qe_udc: Fix recursive locking bug in ch9getstatus()
Date: Tue, 18 Nov 2008 14:13:30 -0800 [thread overview]
Message-ID: <200811181413.30552.david-b@pacbell.net> (raw)
In-Reply-To: <20081118175127.GA29920@oksana.dev.rtsoft.ru>
On Tuesday 18 November 2008, Anton Vorontsov wrote:
> + spin_lock_irqsave(&udc->lock, flags);
> + ret = __qe_ep_queue(_ep, _req, gfp_flags);
> + spin_unlock_irqrestore(&udc->lock, flags);
Why are you passing "gfp_flags"? Especially without
checking ... GFP_KERNEL will be illegal, for example.
next prev parent reply other threads:[~2008-11-18 22:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 16:01 [PATCH 0/6] More QE UDC fixes Anton Vorontsov
2008-11-11 16:03 ` [PATCH 1/6] usb/fsl_qe_udc: Fix oops on QE UDC probe failure Anton Vorontsov
2008-11-18 1:55 ` David Brownell
2008-11-11 16:03 ` [PATCH 2/6] usb/fsl_qe_udc: Fix recursive locking bug in ch9getstatus() Anton Vorontsov
2008-11-18 1:59 ` David Brownell
2008-11-18 17:51 ` [PATCH 2/6 v2] " Anton Vorontsov
2008-11-18 22:13 ` David Brownell [this message]
2008-11-19 0:20 ` [PATCH 2/6 v3] " Anton Vorontsov
2008-11-20 5:41 ` David Brownell
2008-11-11 16:03 ` [PATCH 3/6] usb/fsl_qe_udc: Fix QE USB controller initialization Anton Vorontsov
2008-11-11 16:03 ` [PATCH 4/6] usb/fsl_qe_udc: Fix disconnects reporting during bus reset Anton Vorontsov
2008-11-18 1:48 ` David Brownell
2008-11-11 16:03 ` [PATCH 5/6] usb/fsl_qe_udc: Fix muram corruption by disabled endpoints Anton Vorontsov
2008-11-18 1:52 ` David Brownell
2008-11-11 16:03 ` [PATCH 6/6] usb/fsl_qe_udc: Fix stalled TX requests bug Anton Vorontsov
2008-11-18 1:53 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811181413.30552.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=avorontsov@ru.mvista.com \
--cc=greg@kroah.com \
--cc=leoli@freescale.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.