From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/9] powerpc: port of dynamic ftrace
Date: Thu, 20 Nov 2008 09:13:07 +0100 [thread overview]
Message-ID: <20081120081307.GD21785@elte.hu> (raw)
In-Reply-To: <20081119212204.318400312@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> ----
> arch/powerpc/Kconfig | 2 +
> arch/powerpc/include/asm/ftrace.h | 14 +-
> arch/powerpc/include/asm/module.h | 16 ++-
> arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++---
> arch/powerpc/kernel/idle.c | 5 +
> arch/powerpc/kernel/module_32.c | 10 +
> arch/powerpc/kernel/module_64.c | 13 +
> arch/x86/include/asm/ftrace.h | 9 +-
> arch/x86/kernel/ftrace.c | 168 +++++++++++++-
> include/linux/ftrace.h | 51 ++++-
> kernel/module.c | 2 +-
> kernel/trace/ftrace.c | 137 ++++++------
> scripts/recordmcount.pl | 20 ++-
> 13 files changed, 790 insertions(+), 130 deletions(-)
Hm, something like this shouldnt be pulled into the powerpc tree: it
touches the core kernel, x86 code and ftrace code as well.
Please do the suggestion i outlined and which Paul agreed with:
prepare a branch that touches _only_ powerpc files and gets these
changes there, without actually breaking the build on powerpc. And
please do not name the branch as "hack" - we dont want Paul to pull
such a branch name - it will show up in the upstream git logs.
Those changes should only touch powerpc files. Do not try to shoe-horn
already applied ftrace commits into a separate branch with different
sha1's. Yes, ftrace wont be enable-able on powerpc when that is
pulled, but it will only be for a brief period shortly before the
merge window. (and it will all just work fine when integrated
together)
Once this branch is done, and once Paul agrees that it looks OK-ish to
him, we can put it into ftrace-next straight away [but still keep it
in a separate topic tree in tip/tracing/powerpc - so it can all be
reconsidered reversibly if it causes too much merge trouble]. Paul
will then be able to pull it in a few weeks, in the runup to the
v2.6.29 merge window.
The other option is to go the slow route of 2-3 kernel releases to
pull this all off.
ok?
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Milton Miller <miltonm@bga.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 0/9] powerpc: port of dynamic ftrace
Date: Thu, 20 Nov 2008 09:13:07 +0100 [thread overview]
Message-ID: <20081120081307.GD21785@elte.hu> (raw)
In-Reply-To: <20081119212204.318400312@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> ----
> arch/powerpc/Kconfig | 2 +
> arch/powerpc/include/asm/ftrace.h | 14 +-
> arch/powerpc/include/asm/module.h | 16 ++-
> arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++---
> arch/powerpc/kernel/idle.c | 5 +
> arch/powerpc/kernel/module_32.c | 10 +
> arch/powerpc/kernel/module_64.c | 13 +
> arch/x86/include/asm/ftrace.h | 9 +-
> arch/x86/kernel/ftrace.c | 168 +++++++++++++-
> include/linux/ftrace.h | 51 ++++-
> kernel/module.c | 2 +-
> kernel/trace/ftrace.c | 137 ++++++------
> scripts/recordmcount.pl | 20 ++-
> 13 files changed, 790 insertions(+), 130 deletions(-)
Hm, something like this shouldnt be pulled into the powerpc tree: it
touches the core kernel, x86 code and ftrace code as well.
Please do the suggestion i outlined and which Paul agreed with:
prepare a branch that touches _only_ powerpc files and gets these
changes there, without actually breaking the build on powerpc. And
please do not name the branch as "hack" - we dont want Paul to pull
such a branch name - it will show up in the upstream git logs.
Those changes should only touch powerpc files. Do not try to shoe-horn
already applied ftrace commits into a separate branch with different
sha1's. Yes, ftrace wont be enable-able on powerpc when that is
pulled, but it will only be for a brief period shortly before the
merge window. (and it will all just work fine when integrated
together)
Once this branch is done, and once Paul agrees that it looks OK-ish to
him, we can put it into ftrace-next straight away [but still keep it
in a separate topic tree in tip/tracing/powerpc - so it can all be
reconsidered reversibly if it causes too much merge trouble]. Paul
will then be able to pull it in a few weeks, in the runup to the
v2.6.29 merge window.
The other option is to go the slow route of 2-3 kernel releases to
pull this all off.
ok?
Ingo
next prev parent reply other threads:[~2008-11-20 8:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 21:22 [PATCH 0/9] powerpc: port of dynamic ftrace Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 1/9] ftrace: align __mcount_loc sections Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:32 ` Steven Rostedt
2008-11-19 21:32 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 2/9] NOT FOR MAINLINE ftrace: pass module struct to arch dynamic ftrace functions Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 3/9] powerpc: ftrace, do not latency trace idle Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 4/9] powerpc: ftrace, convert to new dynamic ftrace arch API Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 5/9] powerpc/ppc64: ftrace, mcount record powerpc port Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 6/9] powerpc: ftrace, use probe_kernel API to modify code Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 7/9] powerpc/ppc64: ftrace, handle module trampolines for dyn ftrace Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 8/9] powerpc/ppc32: ftrace, enabled dynamic ftrace Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-19 21:22 ` [PATCH 9/9] powerpc/ppc32: ftrace, dynamic ftrace to handle modules Steven Rostedt
2008-11-19 21:22 ` Steven Rostedt
2008-11-20 8:13 ` Ingo Molnar [this message]
2008-11-20 8:13 ` [PATCH 0/9] powerpc: port of dynamic ftrace Ingo Molnar
2008-11-20 11:58 ` Steven Rostedt
2008-11-20 11:58 ` Steven Rostedt
2008-11-20 14:53 ` Ingo Molnar
2008-11-20 14:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120081307.GD21785@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.