From: David Brownell <david-b@pacbell.net>
To: Peter Barada <peter@the-baradas.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Question regarding OMAP NAND driver read_buf16() function
Date: Thu, 20 Nov 2008 12:53:43 -0800 [thread overview]
Message-ID: <200811201253.43961.david-b@pacbell.net> (raw)
In-Reply-To: <1227208386.27896.239.camel@blackhole>
On Thursday 20 November 2008, Peter Barada wrote:
> In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:
>
> __raw_readsl(nand->IO_ADDR_R, buf, len / 2);
>
> Since len is in bytes (from the comment), shouldn't this either be:
>
> __raw_readsl(nand->IO_ADDR_R, buf, len / 4);
>
> or:
>
> __raw_readsw(nand->IO_ADDR_R, buf, len / 2);
>
Current GIT has the latter. Upgrde your kernel. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-11-20 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 19:13 Question regarding OMAP NAND driver read_buf16() function Peter Barada
2008-11-20 20:53 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811201253.43961.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter@the-baradas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.