All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Barada <peter@the-baradas.com>
To: linux-omap@vger.kernel.org
Subject: Question regarding OMAP NAND driver read_buf16() function
Date: Thu, 20 Nov 2008 14:13:05 -0500	[thread overview]
Message-ID: <1227208386.27896.239.camel@blackhole> (raw)


In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 2);

Since len is in bytes (from the comment), shouldn't this either be:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 4);

or:

	__raw_readsw(nand->IO_ADDR_R, buf, len / 2);
	
-- 
Peter Barada // senior software engineer
 
LOGIC // embedded product solutions
411 Washington Ave. N. Suite 400
Minneapolis, MN 55401
M // 617.513.5874
 
Peter.Barada@logicpd.com
www.logicpd.com


             reply	other threads:[~2008-11-20 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20 19:13 Peter Barada [this message]
2008-11-20 20:53 ` Question regarding OMAP NAND driver read_buf16() function David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227208386.27896.239.camel@blackhole \
    --to=peter@the-baradas.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.