Question regarding OMAP NAND driver read_buf16() function

Question regarding OMAP NAND driver read_buf16() function

[Peter Barada]

In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 2);

Since len is in bytes (from the comment), shouldn't this either be:

	__raw_readsl(nand->IO_ADDR_R, buf, len / 4);

or:

	__raw_readsw(nand->IO_ADDR_R, buf, len / 2);
	
-- 
Peter Barada // senior software engineer
 
LOGIC // embedded product solutions
411 Washington Ave. N. Suite 400
Minneapolis, MN 55401
M // 617.513.5874
 
Peter.Barada@logicpd.com
www.logicpd.com

Re: Question regarding OMAP NAND driver read_buf16() function

[David Brownell]

On Thursday 20 November 2008, Peter Barada wrote:
> In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:
> 
>         __raw_readsl(nand->IO_ADDR_R, buf, len / 2);
> 
> Since len is in bytes (from the comment), shouldn't this either be:
> 
>         __raw_readsl(nand->IO_ADDR_R, buf, len / 4);
> 
> or:
> 
>         __raw_readsw(nand->IO_ADDR_R, buf, len / 2);
>         

Current GIT has the latter.  Upgrde your kernel.  ;)


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html