From: Andi Kleen <andi@firstfloor.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>, kvm@vger.kernel.org
Subject: Re: [PATCH] Fix kvm-79 userland for separate kernel objdir
Date: Thu, 20 Nov 2008 14:48:02 +0100 [thread overview]
Message-ID: <20081120134802.GS6703@one.firstfloor.org> (raw)
In-Reply-To: <200811201422.04693.borntraeger@de.ibm.com>
On Thu, Nov 20, 2008 at 02:22:04PM +0100, Christian Borntraeger wrote:
> Am Donnerstag, 20. November 2008 schrieb Andi Kleen:
> > --- kvm-79/Makefile~ 2008-11-12 12:48:01.000000000 +0100
> > +++ kvm-79/Makefile 2008-11-20 14:06:57.000000000 +0100
> > @@ -33,7 +33,7 @@
> > header-sync-n:
> >
> > header-sync-y:
> > - make -C kernel LINUX=$(KERNELDIR) header-sync
> > + make -C kernel LINUX=$(KERNELSOURCEDIR) header-sync
> > rm -f kernel/include/asm
> > ln -sf asm-$(sane-arch) kernel/include/asm
>
> Hmm. In my config.mak KERNELSOURCEDIR is empty. Looks like
> this patch would break headers_sync on kernels without a separate
> objdirs or builds with configure --kerneldir=blah.
How about this variant? Does it work for you?
-Andi
--- kvm-79/Makefile~ 2008-11-12 12:48:01.000000000 +0100
+++ kvm-79/Makefile 2008-11-20 14:36:54.000000000 +0100
@@ -33,7 +33,9 @@
header-sync-n:
header-sync-y:
- make -C kernel LINUX=$(KERNELDIR) header-sync
+ make -C kernel \
+ LINUX=$(if "$(KERNELSOURCEDIR)",$(KERNELSOURCEDIR),$(KERNELDIR)) \
+ header-sync
rm -f kernel/include/asm
ln -sf asm-$(sane-arch) kernel/include/asm
next prev parent reply other threads:[~2008-11-20 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 13:19 [PATCH] Fix kvm-79 userland for separate kernel objdir Andi Kleen
2008-11-20 13:22 ` Christian Borntraeger
2008-11-20 13:48 ` Andi Kleen [this message]
2008-11-20 13:53 ` Christian Borntraeger
2008-11-20 14:23 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120134802.GS6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.