From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Fix kvm-79 userland for separate kernel objdir
Date: Thu, 20 Nov 2008 14:53:24 +0100 [thread overview]
Message-ID: <200811201453.25032.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20081120134802.GS6703@one.firstfloor.org>
Am Donnerstag, 20. November 2008 schrieb Andi Kleen:
> How about this variant? Does it work for you?
>
> -Andi
>
> --- kvm-79/Makefile~ 2008-11-12 12:48:01.000000000 +0100
> +++ kvm-79/Makefile 2008-11-20 14:36:54.000000000 +0100
> @@ -33,7 +33,9 @@
> header-sync-n:
>
> header-sync-y:
> - make -C kernel LINUX=$(KERNELDIR) header-sync
> + make -C kernel \
> + LINUX=$(if "$(KERNELSOURCEDIR)",$(KERNELSOURCEDIR),$(KERNELDIR)) \
> + header-sync
Nope.
cborntra@cborntra:/space/kvm-userspace$ make
make -C kernel \
LINUX= \
header-sync
fatal: Not a git repository
make[1]: Entering directory `/space/kvm-userspace/kernel'
rm -rf header-tmp
rsync -R \
""/./include/linux/kvm*.h \
\
header-tmp/
rsync: link_stat "/include/linux/kvm*.h" failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at main.c(1058)
[sender=3.0.3]
make[1]: *** [header-sync] Fehler 23
make[1]: Leaving directory `/space/kvm-userspace/kernel'
make: *** [header-sync-y] Fehler 2
But
LINUX=$(if $(KERNELSOURCEDIR),$(KERNELSOURCEDIR),$(KERNELDIR)) \
(without the " )
seems to work.
next prev parent reply other threads:[~2008-11-20 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 13:19 [PATCH] Fix kvm-79 userland for separate kernel objdir Andi Kleen
2008-11-20 13:22 ` Christian Borntraeger
2008-11-20 13:48 ` Andi Kleen
2008-11-20 13:53 ` Christian Borntraeger [this message]
2008-11-20 14:23 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811201453.25032.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.