From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
gregkh@suse.de, k.gantzke@meilhaus.de
Subject: Re: linux-next-20081120 - staging - meilhaus driver build fails
Date: Thu, 20 Nov 2008 21:46:45 +0530 [thread overview]
Message-ID: <20081120161645.GA4821@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081120212907.efc2276b.sfr@canb.auug.org.au>
Hi Stephen,
next-20081120 kernel randconfig on x86_64 box fails, while !CONFIG_MODULES
drivers/staging/meilhaus/memain.c: In function 'me_probe_pci':
drivers/staging/meilhaus/memain.c:425: error: implicit declaration of function '__symbol_get'
drivers/staging/meilhaus/memain.c:425: warning: cast to pointer from integer of different size
drivers/staging/meilhaus/memain.c:433: warning: cast to pointer from integer of different size
drivers/staging/meilhaus/memain.c:453: error: implicit declaration of function '__symbol_put'
make[3]: *** [drivers/staging/meilhaus/memain.o] Error 1
the driver uses __symbol_get and __symbol_put instead of marco's symbol_get and symbol_put,
I have only build tested the patch.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
---
--- linux/drivers/staging/meilhaus/memain.c 2008-11-20 06:08:43.000000000 -0500
+++ linux/drivers/staging/meilhaus/~memain.c 2008-11-20 09:04:15.000000000 -0500
@@ -422,7 +422,7 @@ static int me_probe_pci(struct pci_dev *
PDEBUG("module_name: %s\n", module_name);
if ((constructor =
- (me_pci_constructor_t) __symbol_get(constructor_name)) == NULL) {
+ (me_pci_constructor_t) symbol_get(constructor_name)) == NULL) {
if (request_module(module_name)) {
PERROR("Error while request for module %s.\n",
module_name);
@@ -430,7 +430,7 @@ static int me_probe_pci(struct pci_dev *
}
if ((constructor =
- (me_pci_constructor_t) __symbol_get(constructor_name)) ==
+ (me_pci_constructor_t) symbol_get(constructor_name)) ==
NULL) {
PERROR("Can't get %s driver module constructor.\n",
module_name);
@@ -441,7 +441,7 @@ static int me_probe_pci(struct pci_dev *
if ((device & 0xF000) == 0x4000) { // Bosch build has differnt constructor for me4600.
if ((n_device =
(*constructor_bosch) (dev, me_bosch_fw)) == NULL) {
- __symbol_put(constructor_name);
+ symbol_put(constructor_name);
PERROR
("Can't get device instance of %s driver module.\n",
module_name);
@@ -450,7 +450,7 @@ static int me_probe_pci(struct pci_dev *
} else {
#endif
if ((n_device = (*constructor) (dev)) == NULL) {
- __symbol_put(constructor_name);
+ symbol_put(constructor_name);
PERROR
("Can't get device instance of %s driver module.\n",
module_name);
@@ -503,7 +503,7 @@ static void release_instance(me_device_t
if (plugged != ME_PLUGGED_IN) {
PDEBUG("release: medummy_constructor\n");
- __symbol_put("medummy_constructor");
+ symbol_put("medummy_constructor");
} else {
if ((dev_id & 0xF000) == 0x6000) { // Exceptions: me61xx, me62xx, me63xx are handled by one driver.
dev_id &= 0xF0FF;
@@ -513,7 +513,7 @@ static void release_instance(me_device_t
constructor_name[3] += (char)((dev_id >> 8) & 0x000F);
PDEBUG("release: %s\n", constructor_name);
- __symbol_put(constructor_name);
+ symbol_put(constructor_name);
}
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
next prev parent reply other threads:[~2008-11-20 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 10:29 linux-next: Tree for November 20 Stephen Rothwell
2008-11-20 16:16 ` Kamalesh Babulal [this message]
2008-11-21 19:02 ` linux-next-20081120 - staging - meilhaus driver build fails Greg KH
2008-11-20 17:09 ` linux-next-20081120 - staging - asus_oled device build fails with !CONFIG_USB_SUPPORT Kamalesh Babulal
2008-11-21 19:02 ` Greg KH
2008-11-20 20:52 ` linux-next: Tree for November 20 (staging* [lots]) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120161645.GA4821@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=k.gantzke@meilhaus.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.