All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	k.gantzke@meilhaus.de
Subject: Re: linux-next-20081120 - staging - meilhaus driver build fails
Date: Fri, 21 Nov 2008 11:02:29 -0800	[thread overview]
Message-ID: <20081121190229.GD31017@suse.de> (raw)
In-Reply-To: <20081120161645.GA4821@linux.vnet.ibm.com>

On Thu, Nov 20, 2008 at 09:46:45PM +0530, Kamalesh Babulal wrote:
> Hi Stephen,
> 
>  next-20081120 kernel randconfig on x86_64 box fails, while !CONFIG_MODULES
> 
> drivers/staging/meilhaus/memain.c: In function 'me_probe_pci':
> drivers/staging/meilhaus/memain.c:425: error: implicit declaration of function '__symbol_get'
> drivers/staging/meilhaus/memain.c:425: warning: cast to pointer from integer of different size
> drivers/staging/meilhaus/memain.c:433: warning: cast to pointer from integer of different size
> drivers/staging/meilhaus/memain.c:453: error: implicit declaration of function '__symbol_put'
> make[3]: *** [drivers/staging/meilhaus/memain.o] Error 1
> 
> the driver uses __symbol_get and __symbol_put instead of marco's symbol_get and symbol_put, 
> I have only build tested the patch.

Ick, the code shouldn't be doing any of this :(

I'll work on fixing this up, thanks for pointing it out.

greg k-h

  reply	other threads:[~2008-11-21 19:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20 10:29 linux-next: Tree for November 20 Stephen Rothwell
2008-11-20 16:16 ` linux-next-20081120 - staging - meilhaus driver build fails Kamalesh Babulal
2008-11-21 19:02   ` Greg KH [this message]
2008-11-20 17:09 ` linux-next-20081120 - staging - asus_oled device build fails with !CONFIG_USB_SUPPORT Kamalesh Babulal
2008-11-21 19:02   ` Greg KH
2008-11-20 20:52 ` linux-next: Tree for November 20 (staging* [lots]) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081121190229.GD31017@suse.de \
    --to=gregkh@suse.de \
    --cc=k.gantzke@meilhaus.de \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.