From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/5] powerpc: dynamic ftrace port
Date: Thu, 20 Nov 2008 20:16:50 +0100 [thread overview]
Message-ID: <20081120191650.GD3955@elte.hu> (raw)
In-Reply-To: <20081120190948.057007623@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Paul and Ingo,
>
> The following are the changes to get dynamic ftrace working on PowerPC.
> I modified these a little from the last postings.
>
> 1) I removed the changes to recordmcount.pl. This is not a PowerPC
> change, although PowerPC needs it for dynamic ftrace. But
> the changes here can go via linux-tip.
>
> 2) I removed the adding of HAVE_DYNAMIC_FTRACE and HAVE_FTRACE_MCOUNT_RECORD.
> Without these config options, this code will not be compiled.
> I have a separate patch that adds them in when the time is right.
>
> Paul, these patches should not harm anything if you decide to pull them
> in. As I stated above, without the above config options, they are
> not enabled.
>
> There is one exception and that is for the first patch. The first patch
> is actually a fix for the irqsoff latency tracer which is already
> in mainline for PowerPC.
>
> These patches only touch PowerPC code.
>
> The following patches are in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
>
> branch: ppc/ftrace
>
>
> Steven Rostedt (5):
> powerpc: ftrace, do not latency trace idle
> powerpc: ftrace, convert to new dynamic ftrace arch API
> powerpc: ftrace, use probe_kernel API to modify code
> powerpc/ppc64: ftrace, handle module trampolines for dyn ftrace
> powerpc/ppc32: ftrace, dynamic ftrace to handle modules
>
> ----
> arch/powerpc/include/asm/ftrace.h | 14 +-
> arch/powerpc/include/asm/module.h | 16 ++-
> arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++---
> arch/powerpc/kernel/idle.c | 5 +
> arch/powerpc/kernel/module_32.c | 10 +
> arch/powerpc/kernel/module_64.c | 13 +
> 6 files changed, 489 insertions(+), 42 deletions(-)
looks perfect to me! Thanks Steve for going through this - this was
really a logistical worst-case-scenario.
Now lets hope it looks good to Paul too and we can get his Acked-by
:-)
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@ozlabs.org, Milton Miller <miltonm@bga.com>
Subject: Re: [PATCH 0/5] powerpc: dynamic ftrace port
Date: Thu, 20 Nov 2008 20:16:50 +0100 [thread overview]
Message-ID: <20081120191650.GD3955@elte.hu> (raw)
In-Reply-To: <20081120190948.057007623@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Paul and Ingo,
>
> The following are the changes to get dynamic ftrace working on PowerPC.
> I modified these a little from the last postings.
>
> 1) I removed the changes to recordmcount.pl. This is not a PowerPC
> change, although PowerPC needs it for dynamic ftrace. But
> the changes here can go via linux-tip.
>
> 2) I removed the adding of HAVE_DYNAMIC_FTRACE and HAVE_FTRACE_MCOUNT_RECORD.
> Without these config options, this code will not be compiled.
> I have a separate patch that adds them in when the time is right.
>
> Paul, these patches should not harm anything if you decide to pull them
> in. As I stated above, without the above config options, they are
> not enabled.
>
> There is one exception and that is for the first patch. The first patch
> is actually a fix for the irqsoff latency tracer which is already
> in mainline for PowerPC.
>
> These patches only touch PowerPC code.
>
> The following patches are in:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
>
> branch: ppc/ftrace
>
>
> Steven Rostedt (5):
> powerpc: ftrace, do not latency trace idle
> powerpc: ftrace, convert to new dynamic ftrace arch API
> powerpc: ftrace, use probe_kernel API to modify code
> powerpc/ppc64: ftrace, handle module trampolines for dyn ftrace
> powerpc/ppc32: ftrace, dynamic ftrace to handle modules
>
> ----
> arch/powerpc/include/asm/ftrace.h | 14 +-
> arch/powerpc/include/asm/module.h | 16 ++-
> arch/powerpc/kernel/ftrace.c | 473 +++++++++++++++++++++++++++++++++---
> arch/powerpc/kernel/idle.c | 5 +
> arch/powerpc/kernel/module_32.c | 10 +
> arch/powerpc/kernel/module_64.c | 13 +
> 6 files changed, 489 insertions(+), 42 deletions(-)
looks perfect to me! Thanks Steve for going through this - this was
really a logistical worst-case-scenario.
Now lets hope it looks good to Paul too and we can get his Acked-by
:-)
Ingo
next prev parent reply other threads:[~2008-11-20 19:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 19:09 [PATCH 0/5] powerpc: dynamic ftrace port Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-20 19:09 ` [PATCH 1/5] powerpc: ftrace, do not latency trace idle Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-20 19:09 ` [PATCH 2/5] powerpc: ftrace, convert to new dynamic ftrace arch API Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-24 1:43 ` Paul Mackerras
2008-11-24 1:43 ` Paul Mackerras
2008-11-24 2:49 ` Michael Ellerman
2008-11-24 2:49 ` Michael Ellerman
2008-11-24 18:00 ` Steven Rostedt
2008-11-24 18:00 ` Steven Rostedt
2008-11-20 19:09 ` [PATCH 3/5] powerpc: ftrace, use probe_kernel API to modify code Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-20 19:09 ` [PATCH 4/5] powerpc/ppc64: ftrace, handle module trampolines for dyn ftrace Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-24 2:26 ` Paul Mackerras
2008-11-24 2:26 ` Paul Mackerras
2008-11-24 17:56 ` Steven Rostedt
2008-11-24 17:56 ` Steven Rostedt
2008-11-24 20:59 ` Steven Rostedt
2008-11-24 20:59 ` Steven Rostedt
2008-11-20 19:09 ` [PATCH 5/5] powerpc/ppc32: ftrace, dynamic ftrace to handle modules Steven Rostedt
2008-11-20 19:09 ` Steven Rostedt
2008-11-24 2:35 ` Paul Mackerras
2008-11-24 2:35 ` Paul Mackerras
2008-11-20 19:15 ` [PATCH 0/5] powerpc: dynamic ftrace port Steven Rostedt
2008-11-20 19:15 ` Steven Rostedt
2008-11-20 19:20 ` Ingo Molnar
2008-11-20 19:20 ` Ingo Molnar
2008-11-20 19:16 ` Ingo Molnar [this message]
2008-11-20 19:16 ` Ingo Molnar
2008-11-20 19:24 ` Steven Rostedt
2008-11-20 19:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120191650.GD3955@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.