From: Arnd Bergmann <arnd@arndb.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
kexec@lists.infradead.org, cbe-oss-dev@ozlabs.org,
Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [PATCH] powerpc/mpic: don't reset affinity for secondary MPIC on boot
Date: Fri, 21 Nov 2008 15:40:02 +0100 [thread overview]
Message-ID: <200811211540.03281.arnd@arndb.de> (raw)
In-Reply-To: <1227235450.7185.214.camel@pasglop>
On Friday 21 November 2008, Benjamin Herrenschmidt wrote:
> Oh just that for powermac for example, I know I'm resetting the thing,
> so can't rely on init values, and on some BML embedded boxes too, while
> on things like cell I don't off hand know what the right CPU number is
> to hit the right C3PO interrupt, so I'm better off reading what SLOF
> did :-)
The current code will always use destination 0 for any MPIC, because
mpic_init is run befew smp_init and it currently uses the local CPU.
If an SMP powermac requires a specific destination setting in the
secondary MPIC, either the current mpic_init code is broken there
in the same way as on cell, or more broken if it requires something
other than destination 0.
> But if you think on Cell we can just hard wire in the platform code,
> then I'm ok.
On cell, I know that destination 0 is always correct because of the wiring
inside of Axon.
Arnd <><
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
kexec@lists.infradead.org, cbe-oss-dev@ozlabs.org,
Max Krasnyansky <maxk@qualcomm.com>
Subject: Re: [PATCH] powerpc/mpic: don't reset affinity for secondary MPIC on boot
Date: Fri, 21 Nov 2008 15:40:02 +0100 [thread overview]
Message-ID: <200811211540.03281.arnd@arndb.de> (raw)
In-Reply-To: <1227235450.7185.214.camel@pasglop>
On Friday 21 November 2008, Benjamin Herrenschmidt wrote:
> Oh just that for powermac for example, I know I'm resetting the thing,
> so can't rely on init values, and on some BML embedded boxes too, while
> on things like cell I don't off hand know what the right CPU number is
> to hit the right C3PO interrupt, so I'm better off reading what SLOF
> did :-)
The current code will always use destination 0 for any MPIC, because
mpic_init is run befew smp_init and it currently uses the local CPU.
If an SMP powermac requires a specific destination setting in the
secondary MPIC, either the current mpic_init code is broken there
in the same way as on cell, or more broken if it requires something
other than destination 0.
> But if you think on Cell we can just hard wire in the platform code,
> then I'm ok.
On cell, I know that destination 0 is always correct because of the wiring
inside of Axon.
Arnd <><
next prev parent reply other threads:[~2008-11-21 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 13:50 [PATCH] powerpc/mpic: don't reset affinity for secondary MPIC on boot Arnd Bergmann
2008-11-19 13:50 ` Arnd Bergmann
2008-11-20 7:30 ` Benjamin Herrenschmidt
2008-11-20 7:30 ` Benjamin Herrenschmidt
2008-11-20 17:23 ` Arnd Bergmann
2008-11-20 17:23 ` Arnd Bergmann
2008-11-21 2:44 ` Benjamin Herrenschmidt
2008-11-21 2:44 ` Benjamin Herrenschmidt
2008-11-21 14:40 ` Arnd Bergmann [this message]
2008-11-21 14:40 ` Arnd Bergmann
2008-11-21 22:33 ` Benjamin Herrenschmidt
2008-11-21 22:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811211540.03281.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maxk@qualcomm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.