From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen: pin correct PGD on suspend
Date: Sun, 23 Nov 2008 13:32:41 +0100 [thread overview]
Message-ID: <20081123123241.GH29663@elte.hu> (raw)
In-Reply-To: <4926E2A2.2060602@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ian Campbell wrote:
>> commit eefb47f6a1e855653d275cb90592a3587ea93a09 ("xen: use
>> spin_lock_nest_lock when pinning a pagetable") changed xen_pgd_walk to
>> walk over mm->pgd rather than taking pgd as an argument.
>>
>> This breaks xen_mm_(un)pin_all() because it makes init_mm.pgd readonly
>> instead of the pgd we are interested in and therefore the pin subsequently
>> fails.
>>
>
> Oh, yeah, that was a bit dense. This is needed for .28.
>
> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
applied to tip/x86/urgent, thanks guys!
Ingo
prev parent reply other threads:[~2008-11-23 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 10:21 [PATCH] xen: pin correct PGD on suspend Ian Campbell
2008-11-21 16:32 ` Jeremy Fitzhardinge
2008-11-23 12:32 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123123241.GH29663@elte.hu \
--to=mingo@elte.hu \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.