[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Andrew Beekhof]

Fix a number of LSB compliance issues reported by rpmlint regarding  
ocfs2 init scripts

Signed-off-by: Andrew Beekhof <abeekhof@suse.de>

--- upstream/vendor/common/o2cb.init.sh	2008-09-11 16:51:11.000000000  
+0200
+++ dev/vendor/common/o2cb.init.sh	2008-10-23 14:36:49.000000000 +0200
@@ -8,7 +8,8 @@
  # Provides: o2cb
  # Required-Start: $network
  # Should-Start:
-# Required-Stop:
+# Should-Stop:
+# Required-Stop: $null
  # Default-Start: 2 3 5
  # Default-Stop:
  # Short-Description: Load O2CB cluster services at system boot.
--- upstream/vendor/common/ocfs2.init	2008-09-11 16:51:11.000000000  
+0200
+++ dev/vendor/common/ocfs2.init	2008-10-23 13:13:55.000000000 +0200
@@ -8,9 +8,9 @@
  ### BEGIN INIT INFO
  # Provides: ocfs2
  # Required-Start: $network o2cb
-# Required-Stop:
-# X-UnitedLinux-Should-Start:
-# X-UnitedLinux-Should-Stop:
+# Required-Stop: $null
+# Should-Start:
+# Should-Stop:
  # Default-Start:  2 3 5
  # Default-Stop:
  # Short-Description: Mount OCFS2 volumes at boot.

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Joel Becker]

On Tue, Nov 18, 2008 at 11:18:38AM +0100, Andrew Beekhof wrote:
> Fix a number of LSB compliance issues reported by rpmlint regarding  
> ocfs2 init scripts
> 
> Signed-off-by: Andrew Beekhof <abeekhof@suse.de>
> 
> --- upstream/vendor/common/o2cb.init.sh	2008-09-11 16:51:11.000000000  
> +0200
> +++ dev/vendor/common/o2cb.init.sh	2008-10-23 14:36:49.000000000 +0200
> @@ -8,7 +8,8 @@
>   # Provides: o2cb
>   # Required-Start: $network
>   # Should-Start:
> -# Required-Stop:
> +# Should-Stop:
> +# Required-Stop: $null

	Really, rpmlint requires everyone to know some magic $null?  Who
the heck thought that one up?  Is it portable to all distros?

Joel

-- 

"There is no more evil thing on earth than race prejudice, none at 
 all.  I write deliberately -- it is the worst single thing in life 
 now.  It justifies and holds together more baseness, cruelty and
 abomination than any other sort of error in the world." 
        - H. G. Wells

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Andrew Beekhof]

On Nov 19, 2008, at 12:03 AM, Joel Becker wrote:

> On Tue, Nov 18, 2008 at 11:18:38AM +0100, Andrew Beekhof wrote:
>> Fix a number of LSB compliance issues reported by rpmlint regarding
>> ocfs2 init scripts
>>
>> Signed-off-by: Andrew Beekhof <abeekhof@suse.de>
>>
>> --- upstream/vendor/common/o2cb.init.sh	2008-09-11 16:51:11.000000000
>> +0200
>> +++ dev/vendor/common/o2cb.init.sh	2008-10-23 14:36:49.000000000  
>> +0200
>> @@ -8,7 +8,8 @@
>>  # Provides: o2cb
>>  # Required-Start: $network
>>  # Should-Start:
>> -# Required-Stop:
>> +# Should-Stop:
>> +# Required-Stop: $null
>
> 	Really, rpmlint requires everyone to know some magic $null?  Who
> the heck thought that one up?

Someone with too much time on their hands

> Is it portable to all distros?

I'm assuming yes based on rpmlint being an external project and that  
its vaguely consistent with $network.
But I don't have any other distros to test on - nor the first clue on  
how to check :-/

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Joel Becker]

On Wed, Nov 19, 2008 at 09:02:50AM +0100, Andrew Beekhof wrote:
>
> On Nov 19, 2008, at 12:03 AM, Joel Becker wrote:
>
>> On Tue, Nov 18, 2008 at 11:18:38AM +0100, Andrew Beekhof wrote:
>>> Fix a number of LSB compliance issues reported by rpmlint regarding
>>> ocfs2 init scripts
>>>
>>> Signed-off-by: Andrew Beekhof <abeekhof@suse.de>
>>>
>>> --- upstream/vendor/common/o2cb.init.sh	2008-09-11 16:51:11.000000000
>>> +0200
>>> +++ dev/vendor/common/o2cb.init.sh	2008-10-23 14:36:49.000000000  
>>> +0200
>>> @@ -8,7 +8,8 @@
>>>  # Provides: o2cb
>>>  # Required-Start: $network
>>>  # Should-Start:
>>> -# Required-Stop:
>>> +# Should-Stop:
>>> +# Required-Stop: $null
>>
>> 	Really, rpmlint requires everyone to know some magic $null?  Who
>> the heck thought that one up?
>
> Someone with too much time on their hands
>
>> Is it portable to all distros?
>
> I'm assuming yes based on rpmlint being an external project and that its 
> vaguely consistent with $network.
> But I don't have any other distros to test on - nor the first clue on  
> how to check :-/

	Well, sles10 and rhel5 have plenty of "Required-stop" lines.
Not one of them have $null.  Checking sles11b4, some scripts have $null,
but some still have empty lines "^# Required-Stop:$"
	Actually, let's check LSB.  Latest is 3.2.  Here's the relevant
section:
http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/facilname.html
It states that, "Facility names that begin with a dollar sign ('$') are
reserved system facility names. ... Conforming applications shall not
provide facilities that begin with a dollar sign."  It then lists the
reserved names: $local_fs, $network, $named, $portmap, $remote_fs,
$syslog, and $time.  Thus, $null is actually an *invalid* name.
	Ok, now let's look at sles11.  We find the definition of $null
in the manpage for insserv(8).  "The special facility $null is used to
enforce an empty dependency in case of Should-Stop and Required-Stop
otherwise insserv assumes the same dependencies as for the Start case."
So insserv(8) in sles11 is not LSB compliant.  Its optimization of the
-Stop cases (assume the same as the -Start case) requires an explicit
$null for the empty case.  LSB, conversly, interprets an empty -Stop
line as actually empty.
	rpmlint is wrong here, as it is tracking a SuSE-only behavior.
At least, I can't find a RHEL system that behaves different from LSB.
	Fortunately, the solution is easy.  Our Required-Stop should be
$network, not empty.  We want the network still up when we stop o2cb.
This is valid on both an LSB-compliant system and sles11.

Joel

-- 

"Time is an illusion, lunchtime doubly so."
        -Douglas Adams

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Joel Becker]

On Mon, Nov 24, 2008 at 02:19:40PM -0800, Joel Becker wrote:
> 	rpmlint is wrong here, as it is tracking a SuSE-only behavior.
> At least, I can't find a RHEL system that behaves different from LSB.

	Actually, rpmlint is always wrong.  An empty -Stop line is valid
on sles11 as well - it just means "the same as -Start".

Joel

-- 

"Behind every successful man there's a lot of unsuccessful years."
        - Bob Brown

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Andrew Beekhof]

On Mon, Nov 24, 2008 at 23:30, Joel Becker <Joel.Becker@oracle.com> wrote:
> On Mon, Nov 24, 2008 at 02:19:40PM -0800, Joel Becker wrote:
>>       rpmlint is wrong here, as it is tracking a SuSE-only behavior.
>> At least, I can't find a RHEL system that behaves different from LSB.
>
>        Actually, rpmlint is always wrong.  An empty -Stop line is valid
> on sles11 as well - it just means "the same as -Start".

Ok, just ignore the this patch then.
I've no personal attachment to them... its just something that the
SUSE build system threw up and I wanted to be a good OSS citizen by
submitting it upstream :-)

But its seems there's good reason for it to be rejected as distro-specific.

What about the others and the OCF agent?

[Ocfs2-devel] [Patch 1/3] ocfs2-tools: Resolve rpmlint warnings in init scripts

[Joel Becker]

On Tue, Nov 25, 2008 at 09:35:11AM +0100, Andrew Beekhof wrote:
> On Mon, Nov 24, 2008 at 23:30, Joel Becker <Joel.Becker@oracle.com> wrote:
> > On Mon, Nov 24, 2008 at 02:19:40PM -0800, Joel Becker wrote:
> >>       rpmlint is wrong here, as it is tracking a SuSE-only behavior.
> >> At least, I can't find a RHEL system that behaves different from LSB.
> >
> >        Actually, rpmlint is always wrong.  An empty -Stop line is valid
> > on sles11 as well - it just means "the same as -Start".
> 
> Ok, just ignore the this patch then.
> I've no personal attachment to them... its just something that the
> SUSE build system threw up and I wanted to be a good OSS citizen by
> submitting it upstream :-)

	Did you see the other part, where I stated we should have
"Required-Stop" match "Required-Stop"?  That's the correct change -
valid for LSB and for SLES11.

Joel

-- 

Life's Little Instruction Book #197

	"Don't forget, a person's greatest emotional need is to 
	 feel appreciated."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127