From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: dada1@cosmosbay.com, andi@firstfloor.org, netdev@vger.kernel.org,
minyard@acm.org, christian@myri.com
Subject: Re: [PATCH] net: avoid a pair of dst_hold()/dst_release() in ip_append_data()
Date: Tue, 25 Nov 2008 03:22:32 +0100 [thread overview]
Message-ID: <20081125022232.GE6703@one.firstfloor.org> (raw)
In-Reply-To: <20081124.155531.135918197.davem@davemloft.net>
> Thinking more I believe we can do similar tricks for all TCP
> transmit traffic.
Sounds reasonable.
>
> Packets bound to sockets never outlive those sockets (and thus
> their cached routes) unless we skb_orphan().
>
> The only not covered case is where the socket cached route
> is reset or changed. We could defer the dst put until the
> transmit queue reaches a certain point, kind of like a retransmit
> queue RCU :-)
>
> Just some ideas...
netfilter makes it somewhat tricky, for compatibility you would
need to reclone the route on the fly.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-25 2:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 8:57 [RFC] Could we avoid touching dst->refcount in some cases ? Eric Dumazet
2008-11-24 9:42 ` Andi Kleen
2008-11-24 10:14 ` Eric Dumazet
2008-11-24 11:24 ` [PATCH] net: avoid a pair of dst_hold()/dst_release() in ip_append_data() Eric Dumazet
2008-11-24 13:59 ` [PATCH] net: avoid a pair of dst_hold()/dst_release() in ip_push_pending_frames() Eric Dumazet
2008-11-25 0:07 ` David Miller
2008-11-24 23:55 ` [PATCH] net: avoid a pair of dst_hold()/dst_release() in ip_append_data() David Miller
2008-11-25 2:22 ` Andi Kleen [this message]
2008-11-24 11:27 ` [RFC] Could we avoid touching dst->refcount in some cases ? Andi Kleen
2008-11-24 23:36 ` David Miller
2008-11-24 23:39 ` David Miller
2008-11-25 4:43 ` Eric Dumazet
2008-11-25 5:00 ` David Miller
2008-11-26 0:00 ` [PATCH] net: release skb->dst in sock_queue_rcv_skb() Eric Dumazet
2008-11-26 0:23 ` David Miller
2008-11-26 2:04 ` David Miller
2008-11-26 7:39 ` Eric Dumazet
2008-11-26 9:08 ` David Miller
2008-12-17 11:25 ` net-next: broken IP_PKTINFO [was Re: [PATCH] net: release skb->dst in sock_queue_rcv_skb()] Mark McLoughlin
2008-12-18 3:34 ` net-next: broken IP_PKTINFO David Miller
2008-12-18 5:59 ` Eric Dumazet
2008-12-18 6:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125022232.GE6703@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=christian@myri.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.