From: Jarek Poplawski <jarkao2@gmail.com>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>,
Badalian Vyacheslav <slavon@bigtelecom.ru>,
Denys Fedoryshchenko <denys@visp.net.lb>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: gen_estimator: Fix gen_kill_estimator() lookups
Date: Tue, 25 Nov 2008 07:52:59 +0000 [thread overview]
Message-ID: <20081125075259.GA4265@ff.dom.local> (raw)
In-Reply-To: <1227538858.22481.29.camel@dogo.mojatatu.com>
On Mon, Nov 24, 2008 at 10:00:58AM -0500, jamal wrote:
> On Mon, 2008-11-24 at 13:37 +0000, Jarek Poplawski wrote:
>
> > I first thought about a hash, but alas Patrick's solution is sched
> > only... Anyway, I din't see too much overhead in memory use, and no
> > diffrence in addition times (without batching).
>
> Showing numbers in a commit for perf improvement IMO is always a good
> thing.
Sure, but alas I'm not a perf guy...
> BTW, I dont think it would make a noticeable difference (batching
> notwithstanding) in addition or even deletion unless you have quiet a
> few with the same estimate sampling time loaded.
My very unprofessional tests gave approximately 319s vs. 0.34s with:
"time tc qdisc del dev lo root" for 65535 htb classes, and as you
predicted (and I was surprised) no noticeable difference in addition
times with or without batching.
Cheers,
Jarek P.
next prev parent reply other threads:[~2008-11-25 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 12:04 [PATCH] net: gen_estimator: Fix gen_kill_estimator() lookups Jarek Poplawski
2008-11-24 13:18 ` jamal
2008-11-24 13:37 ` Jarek Poplawski
2008-11-24 15:00 ` jamal
2008-11-25 7:52 ` Jarek Poplawski [this message]
2008-11-24 23:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125075259.GA4265@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=slavon@bigtelecom.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.