All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Update for constraint fix
@ 2008-11-25 14:20 Steven Rostedt
  2008-11-25 14:20 ` [PATCH 1/1] use limited register constraint for setnz Steven Rostedt
  2008-11-25 14:40 ` [PATCH 0/1] Update for constraint fix Ingo Molnar
  0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2008-11-25 14:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ingo Molnar, Andrew Morton, Stephen Rothwell, linux-next,
	Linus Torvalds, H. Peter Anvin, Uros Bizjak


Ingo and Stephen,

Please use this patch instead. Uros Bizjak suggested using 'q' over 'Q'.

The following patches are in:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

    branch: urgent


Steven Rostedt (1):
      use limited register constraint for setnz

----
 arch/x86/boot/tty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] use limited register constraint for setnz
  2008-11-25 14:20 [PATCH 0/1] Update for constraint fix Steven Rostedt
@ 2008-11-25 14:20 ` Steven Rostedt
  2008-11-25 14:40 ` [PATCH 0/1] Update for constraint fix Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2008-11-25 14:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ingo Molnar, Andrew Morton, Stephen Rothwell, linux-next,
	Linus Torvalds, H. Peter Anvin, Uros Bizjak

[-- Attachment #1: 0001-use-limited-register-constraint-for-setnz.patch --]
[-- Type: text/plain, Size: 788 bytes --]

From: Steven Rostedt <rostedt@goodmis.org>

Impact: fix in compiling

GCC can decide to use %dil when "r" is used, which is not valid for
setnz.

This bug was brought out by Stephen Rothwell's merging of the
branch tracer into linux-next.

[ Thanks to Uros Bizjak for recommending 'q' over 'Q' ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 arch/x86/boot/tty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
index 0be77b3..7e8e8b2 100644
--- a/arch/x86/boot/tty.c
+++ b/arch/x86/boot/tty.c
@@ -74,7 +74,7 @@ static int kbd_pending(void)
 {
 	u8 pending;
 	asm volatile("int $0x16; setnz %0"
-		     : "=rm" (pending)
+		     : "=qm" (pending)
 		     : "a" (0x0100));
 	return pending;
 }
-- 
1.5.6.5

-- 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] Update for constraint fix
  2008-11-25 14:20 [PATCH 0/1] Update for constraint fix Steven Rostedt
  2008-11-25 14:20 ` [PATCH 1/1] use limited register constraint for setnz Steven Rostedt
@ 2008-11-25 14:40 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-11-25 14:40 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: linux-kernel, Andrew Morton, Stephen Rothwell, linux-next,
	Linus Torvalds, H. Peter Anvin, Uros Bizjak


* Steven Rostedt <rostedt@goodmis.org> wrote:

> Ingo and Stephen,
> 
> Please use this patch instead. Uros Bizjak suggested using 'q' over 
> 'Q'.
> 
> The following patches are in:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

applied and pushed out into x86-next, thanks Steve!

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-25 14:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-25 14:20 [PATCH 0/1] Update for constraint fix Steven Rostedt
2008-11-25 14:20 ` [PATCH 1/1] use limited register constraint for setnz Steven Rostedt
2008-11-25 14:40 ` [PATCH 0/1] Update for constraint fix Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.