From: "Uwe Kleine-König" <ukleinek@strlen.de>
To: martin f krafft <madduck@debian.org>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] tg export: implement skipping empty patches for quilt mode
Date: Tue, 25 Nov 2008 21:54:40 +0100 [thread overview]
Message-ID: <20081125205440.GA28679@strlen.de> (raw)
In-Reply-To: <20081125084531.GA13122@lapse.rw.madduck.net>
On Tue, Nov 25, 2008 at 09:45:31AM +0100, martin f krafft wrote:
> also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2008.11.24.2256 +0100]:
> > +skipempty=false
>
> Any reason not to make it default? Why do we even need this option?
> Do empty quilt files ever have a purpose?
My first implementation did it unconditionally because I think this
should be the default, too. Then I found in the tg-export section of
README:
TODO: -n option to prevent exporting of empty patches
I'm not sure if this was meant for collapse or quilt or both. I assumed
the last and implemented -n as suggested.
Best regards
Uwe
next prev parent reply other threads:[~2008-11-25 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 21:56 [PATCH] tg export: implement skipping empty patches for quilt mode Uwe Kleine-König
2008-11-25 8:45 ` martin f krafft
2008-11-25 20:54 ` Uwe Kleine-König [this message]
2008-11-26 9:25 ` martin f krafft
2008-11-26 9:47 ` Uwe Kleine-König
[not found] <20081126102507.GA29100@piper.oerlikon.madduck.net>
2008-11-26 12:12 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2008-11-26 12:13 Uwe Kleine-König
2008-11-26 20:39 ` martin f krafft
2008-11-26 21:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125205440.GA28679@strlen.de \
--to=ukleinek@strlen.de \
--cc=git@vger.kernel.org \
--cc=madduck@debian.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.