All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@strlen.de>
To: martin f krafft <madduck@debian.org>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] tg export: implement skipping empty patches for quilt mode
Date: Wed, 26 Nov 2008 10:47:29 +0100	[thread overview]
Message-ID: <20081126094729.GA11169@strlen.de> (raw)
In-Reply-To: <20081126092542.GE25162@piper.oerlikon.madduck.net>

On Wed, Nov 26, 2008 at 10:25:42AM +0100, martin f krafft wrote:
> also sprach Uwe Kleine-König <ukleinek@strlen.de> [2008.11.25.2154 +0100]:
> > 	TODO: -n option to prevent exporting of empty patches
> > 
> > I'm not sure if this was meant for collapse or quilt or both.  I assumed
> > the last and implemented -n as suggested.
> 
> Hm, except...
> 
> +! "$skipempty" || [ "$driver" = "quilt" ] ||
> +       die "-n is only implemented for the quilt driver"
> +
> 
> so you assumed "quilt", not both.
hmm, I *implemented* it only for quilt.  That's also the reason for not
having deleted the todo item.
 
> Anyway, Petr, I'd make this default for all drivers, unless you object.
Ack.

If you want I can prepare a patch, but probably it's easier for you to
amend!?

Best regards
Uwe

  reply	other threads:[~2008-11-26  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 21:56 [PATCH] tg export: implement skipping empty patches for quilt mode Uwe Kleine-König
2008-11-25  8:45 ` martin f krafft
2008-11-25 20:54   ` Uwe Kleine-König
2008-11-26  9:25     ` martin f krafft
2008-11-26  9:47       ` Uwe Kleine-König [this message]
     [not found] <20081126102507.GA29100@piper.oerlikon.madduck.net>
2008-11-26 12:12 ` Uwe Kleine-König
  -- strict thread matches above, loose matches on Subject: below --
2008-11-26 12:13 Uwe Kleine-König
2008-11-26 20:39 ` martin f krafft
2008-11-26 21:19   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126094729.GA11169@strlen.de \
    --to=ukleinek@strlen.de \
    --cc=git@vger.kernel.org \
    --cc=madduck@debian.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.