All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
	dwmw2@infradead.org, jens.axboe@oracle.com, joern@logfs.org,
	James.Bottomley@HansenPartnership.com, djshin90@gmail.com,
	teheo@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] swapfile: swapon randomize if nonrot
Date: Tue, 25 Nov 2008 20:38:16 -0700	[thread overview]
Message-ID: <20081126033815.GF25548@parisc-linux.org> (raw)
In-Reply-To: <20081125172039.c9a35460.akpm@linux-foundation.org>

On Tue, Nov 25, 2008 at 05:20:39PM -0800, Andrew Morton wrote:
> On Tue, 25 Nov 2008 21:46:56 +0000 (GMT)
> Hugh Dickins <hugh@veritas.com> wrote:
> 
> > But how to get my SD card, accessed by USB card reader, reported as NONROT?
> 
> Dunno.  udev rules, perhaps?

I didn't see patch 8/9, but the 'non-rotating' bit is in word 217 of the
inquiry data.  Unfortunately, Jeff insisted that we only report the
contents of that bit for devices claiming ATA-8 support, which is
ridiculous as even the Intel SSDs only claim conformance to ATA-7.

I notice that Jens was allowed to ignore Jeff's insane requirement and
doesn't have to check ATA revision at all.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
	dwmw2@infradead.org, jens.axboe@oracle.com, joern@logfs.org,
	James.Bottomley@HansenPartnership.com, djshin90@gmail.com,
	teheo@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] swapfile: swapon randomize if nonrot
Date: Tue, 25 Nov 2008 20:38:16 -0700	[thread overview]
Message-ID: <20081126033815.GF25548@parisc-linux.org> (raw)
In-Reply-To: <20081125172039.c9a35460.akpm@linux-foundation.org>

On Tue, Nov 25, 2008 at 05:20:39PM -0800, Andrew Morton wrote:
> On Tue, 25 Nov 2008 21:46:56 +0000 (GMT)
> Hugh Dickins <hugh@veritas.com> wrote:
> 
> > But how to get my SD card, accessed by USB card reader, reported as NONROT?
> 
> Dunno.  udev rules, perhaps?

I didn't see patch 8/9, but the 'non-rotating' bit is in word 217 of the
inquiry data.  Unfortunately, Jeff insisted that we only report the
contents of that bit for devices claiming ATA-8 support, which is
ridiculous as even the Intel SSDs only claim conformance to ATA-7.

I notice that Jens was allowed to ignore Jeff's insane requirement and
doesn't have to check ATA revision at all.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-11-26  3:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 21:35 [PATCH 0/9] swapfile: cleanups and solidstate mods Hugh Dickins
2008-11-25 21:36 ` [PATCH 1/9] swapfile: swapon needs larger size type Hugh Dickins
2008-11-25 21:37 ` [PATCH 2/9] swapfile: remove SWP_ACTIVE mask Hugh Dickins
2008-11-25 21:37 ` [PATCH 3/9] swapfile: remove surplus whitespace Hugh Dickins
2008-11-25 21:39 ` [PATCH 4/9] swapfile: remove v0 SWAP-SPACE message Hugh Dickins
2008-11-25 21:40 ` [PATCH 5/9] swapfile: rearrange scan and swap_info Hugh Dickins
2008-11-25 21:44 ` [PATCH 6/9] swapfile: swapon use discard (trim) Hugh Dickins
2008-11-25 21:44   ` Hugh Dickins
2008-11-25 21:46   ` [PATCH 7/9] swapfile: swap allocation use discard Hugh Dickins
2008-11-25 21:46     ` Hugh Dickins
2008-12-01  0:29     ` [PATCH 10/9] swapfile: change discard pgoff_t to sector_t Hugh Dickins
2008-12-01  0:29       ` Hugh Dickins
2008-12-03  0:47       ` Andrew Morton
2008-12-03  0:47         ` Andrew Morton
2008-12-03 12:52         ` Hugh Dickins
2008-12-03 12:52           ` Hugh Dickins
2008-11-25 21:46   ` [PATCH 8/9] swapfile: swapon randomize if nonrot Hugh Dickins
2008-11-25 21:46     ` Hugh Dickins
2008-11-26  1:20     ` Andrew Morton
2008-11-26  1:20       ` Andrew Morton
2008-11-26  3:38       ` Matthew Wilcox [this message]
2008-11-26  3:38         ` Matthew Wilcox
2008-12-01  0:32     ` [PATCH 11/9] swapfile: let others seed random Hugh Dickins
2008-12-01  0:32       ` Hugh Dickins
2008-11-25 21:47   ` [PATCH 9/9] swapfile: swap allocation cycle if nonrot Hugh Dickins
2008-11-25 21:47     ` Hugh Dickins
2008-11-26  1:17   ` [PATCH 6/9] swapfile: swapon use discard (trim) Andrew Morton
2008-11-26  1:17     ` Andrew Morton
2008-11-26  6:02     ` Hugh Dickins
2008-11-26  6:02       ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126033815.GF25548@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=djshin90@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=hugh@veritas.com \
    --cc=jens.axboe@oracle.com \
    --cc=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=teheo@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.