From: Matthew Wilcox <matthew@wil.cx>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mingo@redhat.com, val.henson@gmail.com
Subject: Re: [PATCH 2/2] relatime: Allow making relatime the default behaviour
Date: Wed, 26 Nov 2008 14:11:40 -0700 [thread overview]
Message-ID: <20081126211140.GH25548@parisc-linux.org> (raw)
In-Reply-To: <20081126195824.GB3541@srcf.ucam.org>
On Wed, Nov 26, 2008 at 07:58:24PM +0000, Matthew Garrett wrote:
> +#define MS_NORELATIME (1<<24) /* Disable relatie even if the default */
typo
Otherwise, looks good.
Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
Instead of using __setup, could we use core_param() for these two
parameters? I'm not sure that core_param are exposed in /sys or /proc
anywhere ... if we could fix that, I think it'd simplify this patch
enormously.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-11-26 21:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 19:54 [PATCH 1/2] relatime: Make atime updates more useful Matthew Garrett
2008-11-26 19:58 ` [PATCH 2/2] relatime: Allow making relatime the default behaviour Matthew Garrett
2008-11-26 21:11 ` Matthew Wilcox [this message]
2008-11-26 22:39 ` Randy Dunlap
2008-11-27 15:01 ` [PATCH v2 1/2] relatime: Make relatime behaviour smarter Matthew Garrett
2008-11-27 15:03 ` [PATCH v2 2/2] relatime: Allow making relatime the default behaviour Matthew Garrett
2008-11-27 15:07 ` Ingo Molnar
2008-11-27 16:03 ` Karel Zak
2008-11-27 17:30 ` Pádraig Brady
2008-11-27 17:30 ` Pádraig Brady
2008-11-27 17:39 ` Matthew Garrett
2008-11-27 17:39 ` Matthew Garrett
2008-11-27 16:35 ` Alan Cox
2008-11-27 16:47 ` Matthew Garrett
2008-11-27 16:59 ` [PATCH v3] relatime: Make relatime smarter Matthew Garrett
2008-11-27 17:06 ` Christoph Hellwig
2008-11-27 17:58 ` [PATCH v4] " Matthew Garrett
2008-11-27 22:08 ` Andreas Dilger
2008-11-27 22:35 ` Matthew Wilcox
2008-11-28 11:13 ` Jamie Lokier
2008-11-28 13:41 ` Matthew Garrett
2008-11-28 11:18 ` Jamie Lokier
2008-11-28 13:40 ` Matthew Wilcox
2008-11-28 13:47 ` Matthew Garrett
2008-12-02 11:10 ` Karel Zak
2008-12-02 16:46 ` Matthew Wilcox
2008-11-27 19:15 ` [PATCH v3] " Alan Cox
2008-11-28 11:16 ` Jamie Lokier
2008-11-28 13:45 ` Matthew Garrett
2008-11-27 17:03 ` [PATCH v2 2/2] relatime: Allow making relatime the default behaviour Christoph Hellwig
2008-11-29 8:24 ` Andrew Morton
2008-11-29 13:03 ` Matthew Wilcox
2008-11-29 13:57 ` Jörn Engel
2008-11-29 13:57 ` Jörn Engel
2008-11-29 18:56 ` Jamie Lokier
2008-11-29 18:56 ` Jamie Lokier
2008-11-29 19:02 ` Matthew Garrett
2008-11-29 20:32 ` Andrew Morton
2008-11-29 20:38 ` Matthew Wilcox
2008-11-29 20:56 ` Andrew Morton
2008-11-29 21:41 ` Ingo Molnar
2008-11-29 20:55 ` Arjan van de Ven
2008-11-29 21:03 ` Matthew Garrett
2008-11-29 21:02 ` Matthew Garrett
2008-11-27 15:06 ` [PATCH v2 1/2] relatime: Make relatime behaviour smarter Ingo Molnar
2008-11-29 8:29 ` [PATCH 1/2] relatime: Make atime updates more useful Andrew Morton
2008-12-02 17:19 ` [PATCH] relatime: Let relatime update atime at least once per day Matthew Garrett
2008-12-13 5:26 ` Valerie Aurora Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126211140.GH25548@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=val.henson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.