All of lore.kernel.org
 help / color / mirror / Atom feed
* RFC: drop support for kernels < 2.6.22
@ 2008-11-27  7:32 Hans Verkuil
  2008-11-27  9:41 ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 10+ messages in thread
From: Hans Verkuil @ 2008-11-27  7:32 UTC (permalink / raw)
  To: v4l; +Cc: Mauro Carvalho Chehab

Hi all,

It been my opinion for quite some time now that we are too generous in 
the number of kernel versions we support. I think that the benefits no 
longer outweight the effort we have to put in.

This is true in particular for the i2c support since that changed a lot 
over time. Kernel 2.6.22 is a major milestone for that since it 
introduced the new-style i2c API.

In order to keep the #ifdefs to a minimum I introduced the 
v4l2-i2c-drv.h and v4l2-i2c-drv-legacy.h headers. These make sense when 
used in the v4l-dvb tree context, but when they are stripped and used 
in the actual kernel source they look very weird.

My proposal is to stop supporting kernels < 2.6.22 so that we no longer 
have to put a lot of effort in supporting the old-style i2c API.

In addition, I would suggest that for every new kernel release we also 
drop support for the oldest kernel. The only exception being that once 
2.6.27 is the oldest supported kernel we stick with that one since that 
is the new long-term maintained kernel. Unless we end up again with 
major compatibility issues.

Comments?

Regards,

	Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: RFC: drop support for kernels < 2.6.22
@ 2008-11-27 10:23 Hans Verkuil
  2008-11-27 13:52 ` Andy Walls
  2008-11-27 14:08 ` Mauro Carvalho Chehab
  0 siblings, 2 replies; 10+ messages in thread
From: Hans Verkuil @ 2008-11-27 10:23 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: v4l

> On Thu, 27 Nov 2008 08:32:22 +0100
> Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
>> Hi all,
>>
>> It been my opinion for quite some time now that we are too generous in
>> the number of kernel versions we support. I think that the benefits no
>> longer outweight the effort we have to put in.
>>
>> This is true in particular for the i2c support since that changed a lot
>> over time. Kernel 2.6.22 is a major milestone for that since it
>> introduced the new-style i2c API.
>
> I prefer to keep backward compat with older kernels. Enterprise distros
> like
> RHEL is shipped with older kernels (for example RHEL5 uses kernel 2.6.18).
> We
> should support those kernels.

Is RHEL (or anyone else for that matter) actually using our tree? I never
see any postings about problems or requests for these old kernels on the
v4l list.

Do you know if and how other subsystems handle this?

>
>> In order to keep the #ifdefs to a minimum I introduced the
>> v4l2-i2c-drv.h and v4l2-i2c-drv-legacy.h headers. These make sense when
>> used in the v4l-dvb tree context, but when they are stripped and used
>> in the actual kernel source they look very weird.
>
> We may use a different approach for the above files. For example, we may
> include the headers just for older kernels, like we did in the past with
> i2c
> backward compat with kernel 2.4. gentree can easily remove a #include line
> from
> the upstream patch.

You either using these headers, or you start using lots of #ifdefs in each
i2c driver. There is unfortunately no easy solution to this (I really
tried at the time). Dropping pre-2.6.22 support will make it feasible to
drop these headers. There would still be a few #ifdefs, but it will be
acceptable.

If you know of a distro or big customer that is actually using v4l-dvb on
old kernels, then I think we should keep it, but otherwise it is my
opinion that it is not worth the (substantial) hassle. I also have my
doubts about people using enterprise distros together with v4l. Doesn't
seem very likely to me.

Regards,

       Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: RFC: drop support for kernels < 2.6.22
@ 2008-11-27 14:18 Hans Verkuil
  0 siblings, 0 replies; 10+ messages in thread
From: Hans Verkuil @ 2008-11-27 14:18 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: v4l

> On Thu, 27 Nov 2008 11:23:12 +0100 (CET)
> "Hans Verkuil" <hverkuil@xs4all.nl> wrote:
>
>> > On Thu, 27 Nov 2008 08:32:22 +0100
>> > Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> >
>> >> Hi all,
>> >>
>> >> It been my opinion for quite some time now that we are too generous
>> in
>> >> the number of kernel versions we support. I think that the benefits
>> no
>> >> longer outweight the effort we have to put in.
>> >>
>> >> This is true in particular for the i2c support since that changed a
>> lot
>> >> over time. Kernel 2.6.22 is a major milestone for that since it
>> >> introduced the new-style i2c API.
>> >
>> > I prefer to keep backward compat with older kernels. Enterprise
>> distros
>> > like
>> > RHEL is shipped with older kernels (for example RHEL5 uses kernel
>> 2.6.18).
>> > We
>> > should support those kernels.
>>
>> Is RHEL (or anyone else for that matter) actually using our tree? I
>> never
>> see any postings about problems or requests for these old kernels on the
>> v4l list.
>
> RHEL bugs come to redhat bugzilla. Generated patches there should be
> tested
> against the latest version and applied upstream.
>
>> If you know of a distro or big customer that is actually using v4l-dvb
>> on
>> old kernels, then I think we should keep it, but otherwise it is my
>> opinion that it is not worth the (substantial) hassle. I also have my
>> doubts about people using enterprise distros together with v4l. Doesn't
>> seem very likely to me.
>
> Yes, there are customers with enterprise distros using V4L drivers.
>
> Also, I am using V4L/DVB tree with a 2.6.18 kernel on some machines.
> Removing
> support for 2.6.18 will be a pain for me.
>
> I suspect that Laurent is also using RHEL (or some uvc users), since he
> sent
> some patches fixing compilation with RHEL.

Darn. Oh well, so be it...

Regards,

        Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2008-11-28 10:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-27  7:32 RFC: drop support for kernels < 2.6.22 Hans Verkuil
2008-11-27  9:41 ` Mauro Carvalho Chehab
2008-11-27 14:22   ` Douglas Schilling Landgraf
  -- strict thread matches above, loose matches on Subject: below --
2008-11-27 10:23 Hans Verkuil
2008-11-27 13:52 ` Andy Walls
2008-11-27 15:54   ` Jackson Yee
2008-11-27 14:08 ` Mauro Carvalho Chehab
2008-11-27 14:20   ` Laurent Pinchart
2008-11-28 10:10     ` Darren Longhorn
2008-11-27 14:18 Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.