From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@nokia.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 11/11] ARM: OMAP: Switch ohci-omap to gpio_request/free calls
Date: Fri, 28 Nov 2008 17:35:36 -0800 [thread overview]
Message-ID: <200811281735.37174.david-b@pacbell.net> (raw)
In-Reply-To: <20081129011104.12337.37890.stgit@localhost>
On Friday 28 November 2008, Tony Lindgren wrote:
> From: Jarkko Nikula <jarkko.nikula@nokia.com>
>
> Switch to gpio_request/free calls
>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Best if this merges through the ARM tree, with other similar
changes, since ISTR this won't apply as-is through the USB tree.
> ---
> drivers/usb/host/ohci-omap.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
> index 22f6d19..4bbddb7 100644
> --- a/drivers/usb/host/ohci-omap.c
> +++ b/drivers/usb/host/ohci-omap.c
> @@ -18,6 +18,7 @@
> #include <linux/jiffies.h>
> #include <linux/platform_device.h>
> #include <linux/clk.h>
> +#include <linux/gpio.h>
>
> #include <mach/hardware.h>
> #include <asm/io.h>
> @@ -25,7 +26,6 @@
>
> #include <mach/mux.h>
> #include <mach/irqs.h>
> -#include <mach/gpio.h>
> #include <mach/fpga.h>
> #include <mach/usb.h>
>
> @@ -254,7 +254,7 @@ static int ohci_omap_init(struct usb_hcd *hcd)
>
> /* gpio9 for overcurrent detction */
> omap_cfg_reg(W8_1610_GPIO9);
> - omap_request_gpio(9);
> + gpio_request(9, "OHCI overcurrent");
> gpio_direction_input(9);
>
> /* for paranoia's sake: disable USB.PUEN */
> @@ -407,7 +407,7 @@ usb_hcd_omap_remove (struct usb_hcd *hcd, struct platform_device *pdev)
> put_device(ohci->transceiver->dev);
> }
> if (machine_is_omap_osk())
> - omap_free_gpio(9);
> + gpio_free(9);
> iounmap(hcd->regs);
> release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
> usb_put_hcd(hcd);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2008-11-29 1:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 1:09 [PATCH 00/11] Omap gpio updates for review for 2.6.29 merge window Tony Lindgren
2008-11-29 1:09 ` [PATCH 01/11] ARM: OMAP: Enable GPIO debounce clock only when debounce is enabled v3 Tony Lindgren
2008-11-29 1:09 ` [PATCH 02/11] ARM: OMAP: Extend gpio label column width in omap_gpio debugfs file Tony Lindgren
2008-11-29 1:10 ` [PATCH 03/11] ARM: OMAP: gpios implement new to_irq() Tony Lindgren
2008-11-29 1:10 ` [PATCH 04/11] ARM: OMAP: switch to standard gpio get/set calls Tony Lindgren
2008-11-29 1:10 ` [PATCH 05/11] ARM: OMAP: switch to gpio_direction_input Tony Lindgren
2008-11-29 1:10 ` [PATCH 06/11] ARM: OMAP: switch to gpio_direction_output Tony Lindgren
2008-11-29 1:10 ` [PATCH 07/11] ARM: OMAP: use gpio_to_irq Tony Lindgren
2008-11-29 1:10 ` [PATCH 08/11] ARM: OMAP: make legacy gpio request/free calls superfluous Tony Lindgren
2008-11-29 1:10 ` [PATCH 09/11] ARM: OMAP: minor gpio bugfixes Tony Lindgren
2008-11-29 1:10 ` [PATCH 10/11] ARM: OMAP: Switch to gpio_request/free calls Tony Lindgren
2008-12-09 1:29 ` [PATCH 10/11] ARM: OMAP: Switch to gpio_request/free calls, v2 Tony Lindgren
2008-11-29 1:11 ` [PATCH 11/11] ARM: OMAP: Switch ohci-omap to gpio_request/free calls Tony Lindgren
2008-11-29 1:35 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811281735.37174.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=jarkko.nikula@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.