All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 1/3] parisc/lib/: make code static
@ 2008-12-01 22:28 akpm
  2008-12-02  5:45 ` Grant Grundler
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-12-01 22:28 UTC (permalink / raw)
  To: kyle; +Cc: linux-parisc, akpm, bunk, grundler, matthew

From: Adrian Bunk <bunk@kernel.org>

Make the following needlessly global code static:

- iomap.c: struct iomap_ops[]
- memcpy.c: pa_memcpy()

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/parisc/lib/iomap.c  |    2 +-
 arch/parisc/lib/memcpy.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/parisc/lib/iomap.c~parisc-lib-make-code-static arch/parisc/lib/iomap.c
--- a/arch/parisc/lib/iomap.c~parisc-lib-make-code-static
+++ a/arch/parisc/lib/iomap.c
@@ -261,7 +261,7 @@ static const struct iomap_ops iomem_ops 
 	iomem_write32r,
 };
 
-const struct iomap_ops *iomap_ops[8] = {
+static const struct iomap_ops *iomap_ops[8] = {
 	[0] = &ioport_ops,
 	[7] = &iomem_ops
 };
diff -puN arch/parisc/lib/memcpy.c~parisc-lib-make-code-static arch/parisc/lib/memcpy.c
--- a/arch/parisc/lib/memcpy.c~parisc-lib-make-code-static
+++ a/arch/parisc/lib/memcpy.c
@@ -275,7 +275,7 @@ handle_store_error:
 
 
 /* Returns 0 for success, otherwise, returns number of bytes not transferred. */
-unsigned long pa_memcpy(void *dstp, const void *srcp, unsigned long len)
+static unsigned long pa_memcpy(void *dstp, const void *srcp, unsigned long len)
 {
 	register unsigned long src, dst, t1, t2, t3;
 	register unsigned char *pcs, *pcd;
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/3] parisc/lib/: make code static
  2008-12-01 22:28 [patch 1/3] parisc/lib/: make code static akpm
@ 2008-12-02  5:45 ` Grant Grundler
  0 siblings, 0 replies; 2+ messages in thread
From: Grant Grundler @ 2008-12-02  5:45 UTC (permalink / raw)
  To: akpm; +Cc: kyle, linux-parisc, bunk, grundler, matthew

On Mon, Dec 01, 2008 at 02:28:15PM -0800, akpm@linux-foundation.org wrote:
> From: Adrian Bunk <bunk@kernel.org>
> 
> Make the following needlessly global code static:
> 
> - iomap.c: struct iomap_ops[]
> - memcpy.c: pa_memcpy()
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Cc: Kyle McMartin <kyle@mcmartin.ca>
> Cc: Matthew Wilcox <matthew@wil.cx>
> Cc: Grant Grundler <grundler@parisc-linux.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Reviewed-by: Grant Grundler <grundler@parisc-linux.org>

thanks,
grant

> ---
> 
>  arch/parisc/lib/iomap.c  |    2 +-
>  arch/parisc/lib/memcpy.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff -puN arch/parisc/lib/iomap.c~parisc-lib-make-code-static arch/parisc/lib/iomap.c
> --- a/arch/parisc/lib/iomap.c~parisc-lib-make-code-static
> +++ a/arch/parisc/lib/iomap.c
> @@ -261,7 +261,7 @@ static const struct iomap_ops iomem_ops 
>  	iomem_write32r,
>  };
>  
> -const struct iomap_ops *iomap_ops[8] = {
> +static const struct iomap_ops *iomap_ops[8] = {
>  	[0] = &ioport_ops,
>  	[7] = &iomem_ops
>  };
> diff -puN arch/parisc/lib/memcpy.c~parisc-lib-make-code-static arch/parisc/lib/memcpy.c
> --- a/arch/parisc/lib/memcpy.c~parisc-lib-make-code-static
> +++ a/arch/parisc/lib/memcpy.c
> @@ -275,7 +275,7 @@ handle_store_error:
>  
>  
>  /* Returns 0 for success, otherwise, returns number of bytes not transferred. */
> -unsigned long pa_memcpy(void *dstp, const void *srcp, unsigned long len)
> +static unsigned long pa_memcpy(void *dstp, const void *srcp, unsigned long len)
>  {
>  	register unsigned long src, dst, t1, t2, t3;
>  	register unsigned char *pcs, *pcd;
> _

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-02  5:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 22:28 [patch 1/3] parisc/lib/: make code static akpm
2008-12-02  5:45 ` Grant Grundler

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.