All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Cc: fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	srostedt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	mingo-X9Un+BFzKDI@public.gmane.org,
	sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH 1/3] ftrace: graph of a single function
Date: Wed, 3 Dec 2008 13:07:41 -0800	[thread overview]
Message-ID: <20081203130741.473c1262.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081203203828.920111079-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>

On Wed, 03 Dec 2008 15:36:57 -0500
Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote:

> +static int g_show(struct seq_file *m, void *v)
> +{
> +	unsigned long *ptr = v;
> +	char str[KSYM_SYMBOL_LEN];
> +
> +	if (!ptr)
> +		return 0;
> +
> +	kallsyms_lookup(*ptr, NULL, NULL, NULL, str);
> +
> +	seq_printf(m, "%s\n", str);

Can we use %pF here?

> +	return 0;
> +}

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, fweisbec@gmail.com,
	peterz@infradead.org, arjan@infradead.org,
	dave@linux.vnet.ibm.com, containers@lists.osdl.org,
	ebiederm@xmission.com, sukadev@linux.vnet.ibm.com,
	serue@us.ibm.com, srostedt@redhat.com
Subject: Re: [PATCH 1/3] ftrace: graph of a single function
Date: Wed, 3 Dec 2008 13:07:41 -0800	[thread overview]
Message-ID: <20081203130741.473c1262.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081203203828.920111079@goodmis.org>

On Wed, 03 Dec 2008 15:36:57 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> +static int g_show(struct seq_file *m, void *v)
> +{
> +	unsigned long *ptr = v;
> +	char str[KSYM_SYMBOL_LEN];
> +
> +	if (!ptr)
> +		return 0;
> +
> +	kallsyms_lookup(*ptr, NULL, NULL, NULL, str);
> +
> +	seq_printf(m, "%s\n", str);

Can we use %pF here?

> +	return 0;
> +}

  parent reply	other threads:[~2008-12-03 21:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 20:36 [PATCH 0/3] ftrace: updates for tip Steven Rostedt
2008-12-03 20:36 ` [PATCH 1/3] ftrace: graph of a single function Steven Rostedt
2008-12-03 20:36   ` Steven Rostedt
     [not found]   ` <20081203203828.920111079-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
2008-12-03 21:07     ` Andrew Morton [this message]
2008-12-03 21:07       ` Andrew Morton
2008-12-03 21:10       ` Steven Rostedt
2008-12-03 21:32         ` Andrew Morton
2008-12-03 21:36           ` Steven Rostedt
2008-12-04  8:39             ` Ingo Molnar
2008-12-03 21:08     ` Andrew Morton
2008-12-03 21:08       ` Andrew Morton
2008-12-03 21:11       ` Steven Rostedt
2008-12-04  8:41         ` Ingo Molnar
2008-12-04  8:43           ` Peter Zijlstra
2008-12-15  9:21           ` Andy Whitcroft
2008-12-04  6:24   ` [PATCH 1/1] ftrace: avoid duplicated function when writing set_graph_function Liming Wang
2008-12-04  8:42     ` Ingo Molnar
2008-12-03 20:36 ` [PATCH 2/3] ftrace: use task struct trace flag to filter on pid Steven Rostedt
2008-12-03 22:34   ` Eric W. Biederman
2008-12-03 20:36 ` [PATCH 3/3] ftrace: trace single pid for function graph tracer Steven Rostedt
2008-12-03 20:49   ` Andrew Morton
2008-12-03 20:52     ` Steven Rostedt
2008-12-03 23:36       ` Eric W. Biederman
2008-12-04  2:29         ` Steven Rostedt
2008-12-04  4:22           ` Eric W. Biederman
2008-12-04  4:32             ` Steven Rostedt
2008-12-04  8:19 ` [PATCH 0/3] ftrace: updates for tip Ingo Molnar
2008-12-04  8:35 ` Ingo Molnar
2008-12-04 13:30   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203130741.473c1262.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=arjan-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
    --cc=srostedt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.