From: Johannes Weiner <hannes@cmpxchg.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jdike@addtoit.com, LKML <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [Patch] uml: drop const qualifier for kernel_execve()
Date: Wed, 3 Dec 2008 14:40:35 +0100 [thread overview]
Message-ID: <20081203134035.GA17560@cmpxchg.org> (raw)
In-Reply-To: <2375c9f90812030432m771984edkdd0c599bbae9bb3c@mail.gmail.com>
On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote:
> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote:
> >> UML implementation of kernel_execve() should not have const qualifier,
> >> because it will finally call do_execve() which doesn't have.
> >
> > And you made sure that do_execve() is correctly annotated?
> >
>
> Yes, I checked that.
Good. Then please fix up do_execve() or let the warning stand out as
a reminder.
Hannes
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [Patch] uml: drop const qualifier for kernel_execve()
Date: Wed, 3 Dec 2008 14:40:35 +0100 [thread overview]
Message-ID: <20081203134035.GA17560@cmpxchg.org> (raw)
In-Reply-To: <2375c9f90812030432m771984edkdd0c599bbae9bb3c@mail.gmail.com>
On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote:
> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote:
> >> UML implementation of kernel_execve() should not have const qualifier,
> >> because it will finally call do_execve() which doesn't have.
> >
> > And you made sure that do_execve() is correctly annotated?
> >
>
> Yes, I checked that.
Good. Then please fix up do_execve() or let the warning stand out as
a reminder.
Hannes
next prev parent reply other threads:[~2008-12-03 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 22:51 [uml-devel] [Patch] uml: drop const qualifier for kernel_execve() Américo Wang
2008-12-02 22:51 ` Américo Wang
2008-12-03 1:20 ` [uml-devel] " Johannes Weiner
2008-12-03 1:20 ` Johannes Weiner
2008-12-03 12:32 ` [uml-devel] " Américo Wang
2008-12-03 12:32 ` Américo Wang
2008-12-03 13:40 ` Johannes Weiner [this message]
2008-12-03 13:40 ` Johannes Weiner
2008-12-06 1:02 ` [uml-devel] " Américo Wang
2008-12-06 1:02 ` Américo Wang
2008-12-07 19:55 ` [uml-devel] " Johannes Weiner
2008-12-07 19:55 ` Johannes Weiner
2008-12-26 9:32 ` [uml-devel] " Américo Wang
2008-12-26 9:32 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203134035.GA17560@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.