From: Frans Pop <elendil@planet.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: rjw@sisk.pl, wim@iguana.be, linux-acpi@vger.kernel.org,
akpm@linux-foundation.org, lenb@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Regression from 2.6.28-rc7: Commit 7cd5b08be3 breaks startup on Toshiba Portege R500
Date: Thu, 4 Dec 2008 00:13:32 +0100 [thread overview]
Message-ID: <200812040013.34009.elendil@planet.nl> (raw)
In-Reply-To: <alpine.LFD.2.00.0812031412060.3256@nehalem.linux-foundation.org>
> Hmm. I wonder if the bug is this one-liner (it really looks like an
> idiotic typo).
>
> Can you test?
>
> drivers/watchdog/iTCO_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 26173a2..5b395a4 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -392,7 +392,7 @@ static int iTCO_wdt_stop(void)
>
> /* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI#
> */ val32 = inl(SMI_EN);
> - val32 &= 0x00002000;
> + val32 |= 0x00002000;
> outl(val32, SMI_EN);
>
> /* Set the NO_REBOOT bit to prevent later reboots, just for
> sure */
Fixes my X.Org issue (http://lkml.org/lkml/2008/12/3/178).
Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Frans Pop <elendil@planet.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: rjw@sisk.pl, wim@iguana.be, linux-acpi@vger.kernel.org,
akpm@linux-foundation.org, lenb@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Regression from 2.6.28-rc7: Commit 7cd5b08be3 breaks startup on Toshiba Portege R500
Date: Thu, 4 Dec 2008 00:13:32 +0100 [thread overview]
Message-ID: <200812040013.34009.elendil@planet.nl> (raw)
In-Reply-To: <alpine.LFD.2.00.0812031412060.3256@nehalem.linux-foundation.org>
> Hmm. I wonder if the bug is this one-liner (it really looks like an
> idiotic typo).
>
> Can you test?
>
> drivers/watchdog/iTCO_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 26173a2..5b395a4 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -392,7 +392,7 @@ static int iTCO_wdt_stop(void)
>
> /* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI#
> */ val32 = inl(SMI_EN);
> - val32 &= 0x00002000;
> + val32 |= 0x00002000;
> outl(val32, SMI_EN);
>
> /* Set the NO_REBOOT bit to prevent later reboots, just for
> sure */
Fixes my X.Org issue (http://lkml.org/lkml/2008/12/3/178).
Cheers,
FJP
next prev parent reply other threads:[~2008-12-03 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 22:00 Regression from 2.6.28-rc7: Commit 7cd5b08be3 breaks startup on Toshiba Portege R500 Rafael J. Wysocki
2008-12-03 22:17 ` Linus Torvalds
2008-12-03 23:13 ` Frans Pop [this message]
2008-12-03 23:13 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812040013.34009.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.