All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jianjun Kong <jianjun@zeuux.org>
To: rusty@rustcorp.com.au
Cc: Linux-Kernel-Mailing-List <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] fix warning of not used variable
Date: Thu, 4 Dec 2008 09:00:22 +0800	[thread overview]
Message-ID: <20081204010022.GB17445@ubuntu> (raw)


fix this warning:
kernel/module.c:824: warning: ‘print_unload_info’ defined but not used
print_unload_info() just used when CONFIG_PROC_FS was defined.

Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
---
 kernel/module.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 1f4cc00..20b5d25 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -820,6 +820,7 @@ sys_delete_module(const char __user *name_user, unsigned int flags)
 	return ret;
 }
 
+#ifdef CONFIG_PROC_FS
 static void print_unload_info(struct seq_file *m, struct module *mod)
 {
 	struct module_use *use;
@@ -842,6 +843,7 @@ static void print_unload_info(struct seq_file *m, struct module *mod)
 	if (!printed_something)
 		seq_printf(m, "-");
 }
+#endif
 
 void __symbol_put(const char *symbol)
 {
@@ -893,11 +895,14 @@ void module_put(struct module *module)
 EXPORT_SYMBOL(module_put);
 
 #else /* !CONFIG_MODULE_UNLOAD */
+
+#ifdef CONFIG_PROC_FS
 static void print_unload_info(struct seq_file *m, struct module *mod)
 {
 	/* We don't know the usage count, or what modules are using. */
 	seq_printf(m, " - -");
 }
+#endif
 
 static inline void module_unload_free(struct module *mod)
 {
-- 
1.5.6.3

-- 
Jianjun Kong | Happy Hacking
HOMEPAGE: http://kongove.cn/
GTALK: kongjianjun@gmail.com

             reply	other threads:[~2008-12-04  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  1:00 Jianjun Kong [this message]
2008-12-04 10:12 ` [PATCH 2/3] fix warning of not used variable Ingo Molnar
2008-12-04 11:34   ` Américo Wang
2008-12-04 11:36 ` Américo Wang
2008-12-05  0:01   ` Rusty Russell
2008-12-06  0:52     ` Américo Wang
2008-12-06  2:29       ` Jianjun Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081204010022.GB17445@ubuntu \
    --to=jianjun@zeuux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.