From: Rusty Russell <rusty@rustcorp.com.au>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: "Jianjun Kong" <jianjun@zeuux.org>,
"Linux-Kernel-Mailing-List" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/3] fix warning of not used variable
Date: Fri, 5 Dec 2008 10:31:07 +1030 [thread overview]
Message-ID: <200812051031.08121.rusty@rustcorp.com.au> (raw)
In-Reply-To: <2375c9f90812040336r498cfefbta51b2ae2689a3d5f@mail.gmail.com>
On Thursday 04 December 2008 22:06:33 Américo Wang wrote:
> On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@zeuux.org> wrote:
> > fix this warning:
> > kernel/module.c:824: warning: 'print_unload_info' defined but not used
> > print_unload_info() just used when CONFIG_PROC_FS was defined.
> >
> > Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
>
> Reviewed-by: WANG Cong <wangcong@zeuux.org>
My main concern is that this adds two new #ifdef sections. How about marking
both cases "inline" instead?
Cheers,
Rusty.
next prev parent reply other threads:[~2008-12-05 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 1:00 [PATCH 2/3] fix warning of not used variable Jianjun Kong
2008-12-04 10:12 ` Ingo Molnar
2008-12-04 11:34 ` Américo Wang
2008-12-04 11:36 ` Américo Wang
2008-12-05 0:01 ` Rusty Russell [this message]
2008-12-06 0:52 ` Américo Wang
2008-12-06 2:29 ` Jianjun Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812051031.08121.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jianjun@zeuux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.