From: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Alexander Beregalov
<a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
mingo-X9Un+BFzKDI@public.gmane.org,
venkatesh.pallipadi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: 2.6.28-rc6: hpet: object is on stack, but not annotated
Date: Thu, 4 Dec 2008 12:16:21 +0100 [thread overview]
Message-ID: <20081204111621.GA2466@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.0811241916560.3301-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Mon 2008-11-24 19:17:44, Thomas Gleixner wrote:
> On Mon, 24 Nov 2008, Alexander Beregalov wrote:
>
> > 2008/11/24 Alexander Beregalov <a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> > > hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0
> > > hpet0: 3 comparators, 64-bit 14.318180 MHz counter
> > > ODEBUG: object is on stack, but not annotated
> > > ------------[ cut here ]------------
> > > WARNING: at lib/debugobjects.c:251 __debug_object_init+0x2a4/0x352()
> >
> > Bisected down to 26afe5f2fbf06ea0765aaa316640c4dd472310c0
> > (x86: HPET_MSI Initialise per-cpu HPET timers)
> >
> > Revert helps
>
> That's just a warning about a missing annotation. The commit is fine.
You must be using very different metric of what "fine" means than rest
of the world.
(No, introducing WARN_ON()s is not fine; it spams kerneloops.org at least...)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@suse.cz>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
mingo@elte.hu, venkatesh.pallipadi@intel.com,
shaohua.li@intel.com
Subject: Re: 2.6.28-rc6: hpet: object is on stack, but not annotated
Date: Thu, 4 Dec 2008 12:16:21 +0100 [thread overview]
Message-ID: <20081204111621.GA2466@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.0811241916560.3301@localhost.localdomain>
On Mon 2008-11-24 19:17:44, Thomas Gleixner wrote:
> On Mon, 24 Nov 2008, Alexander Beregalov wrote:
>
> > 2008/11/24 Alexander Beregalov <a.beregalov@gmail.com>:
> > > hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0
> > > hpet0: 3 comparators, 64-bit 14.318180 MHz counter
> > > ODEBUG: object is on stack, but not annotated
> > > ------------[ cut here ]------------
> > > WARNING: at lib/debugobjects.c:251 __debug_object_init+0x2a4/0x352()
> >
> > Bisected down to 26afe5f2fbf06ea0765aaa316640c4dd472310c0
> > (x86: HPET_MSI Initialise per-cpu HPET timers)
> >
> > Revert helps
>
> That's just a warning about a missing annotation. The commit is fine.
You must be using very different metric of what "fine" means than rest
of the world.
(No, introducing WARN_ON()s is not fine; it spams kerneloops.org at least...)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-12-04 11:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 16:39 2.6.28-rc6: hpet: object is on stack, but not annotated Alexander Beregalov
[not found] ` <a4423d670811240839q54e6b7afxfc49d28b3ea127cb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-24 18:14 ` Alexander Beregalov
2008-11-24 18:14 ` Alexander Beregalov
[not found] ` <a4423d670811241014n2b2192beh931d374bf063894f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-24 18:17 ` Thomas Gleixner
2008-11-24 18:17 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0811241916560.3301-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-12-04 11:16 ` Pavel Machek [this message]
2008-12-04 11:16 ` Pavel Machek
[not found] ` <20081204111621.GA2466-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-01-12 10:40 ` Alexander Beregalov
2009-01-12 10:40 ` Alexander Beregalov
2009-01-12 11:52 ` Peter Zijlstra
2009-01-12 11:59 ` Ingo Molnar
2009-01-12 11:59 ` Ingo Molnar
[not found] ` <20090112115934.GA24266-X9Un+BFzKDI@public.gmane.org>
2009-01-12 12:27 ` Alexander Beregalov
2009-01-12 12:27 ` Alexander Beregalov
[not found] ` <a4423d670901120427q502ae9b6uded2e55a91c2a7cc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-12 12:33 ` Ingo Molnar
2009-01-12 12:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204111621.GA2466@elf.ucw.cz \
--to=pavel-alswssmvlrq@public.gmane.org \
--cc=a.beregalov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=venkatesh.pallipadi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.