From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Stephen Hemminger <shemminger@vyatta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Yet more ARM breakage in linux-next
Date: Thu, 4 Dec 2008 11:57:14 +1030 [thread overview]
Message-ID: <200812041157.15355.rusty@rustcorp.com.au> (raw)
In-Reply-To: <49371848.2080804@oracle.com>
On Thursday 04 December 2008 10:07:44 Randy Dunlap wrote:
> Rusty Russell wrote:
> > (Yes, classic useless kerneldoc documentation doesn't actually *say*
> > this clearly).
>
> oh fud. That's not a fault of kernel-doc, just of whoever wrote it.
> It's only as good as someone makes it.
Sorry that this came out wrong. kernel-doc provides structure, but it can't
provide content. And authors seem unable to think from the POV of someone
*using* the API.
With some work, I tracked it back to Stephen Hemminger for this comment in
12d9c8420b9daa1da3d9e090640fb24bcd0deba2. It's since been fixed and moved,
but it's still:
* __fls: find last set bit in word
* @word: The word to search
*
* Undefined if no set bit exists, so code should check against 0 first.
Which would be *fine* if fls() didn't have such confusing bit numbering and
the exact same one-line description.
Thanks,
Rusty.
next prev parent reply other threads:[~2008-12-04 1:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 19:29 Yet more ARM breakage in linux-next Russell King
2008-12-03 20:41 ` Andrew Morton
2008-12-03 23:22 ` Rusty Russell
2008-12-03 23:37 ` Randy Dunlap
2008-12-03 23:46 ` Andrew Morton
2008-12-04 0:10 ` Alan Cox
2008-12-04 0:01 ` David Miller
2008-12-04 0:18 ` Randy Dunlap
2008-12-04 1:27 ` Rusty Russell [this message]
2008-12-04 2:56 ` Stephen Hemminger
2008-12-04 0:31 ` Russell King
2008-12-04 3:06 ` Nicolas Pitre
2008-12-04 1:33 ` Mike Frysinger
2008-12-04 2:15 ` Rusty Russell
2008-12-04 3:55 ` Mike Frysinger
2008-12-04 9:18 ` Geert Uytterhoeven
2008-12-04 14:12 ` Rusty Russell
2008-12-07 21:50 ` Geert Uytterhoeven
2008-12-08 6:20 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812041157.15355.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sfr@canb.auug.org.au \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.