All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: Yet more ARM breakage in linux-next
Date: Fri, 5 Dec 2008 00:42:27 +1030	[thread overview]
Message-ID: <200812050042.28222.rusty@rustcorp.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0812041017470.10635@anakin>

On Thursday 04 December 2008 19:48:06 Geert Uytterhoeven wrote:
> Also broke m68k (a bit more hidden due to other build failures).

And m68knommu has similar issues.

Here's what I have for m68k for tomorrow's linux-next.  Please steal.

m68k: define __fls

Like fls, but can't be handed 0 and returns the bit number.

(I broke this arch in linux-next by using __fls in generic code).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/include/asm-m68k/bitops.h b/include/asm-m68k/bitops.h
--- a/include/asm-m68k/bitops.h
+++ b/include/asm-m68k/bitops.h
@@ -315,6 +315,11 @@ static inline int fls(int x)
 	return 32 - cnt;
 }
 
+static inline int __fls(int x)
+{
+	return fls(x) - 1;
+}
+
 #include <asm-generic/bitops/fls64.h>
 #include <asm-generic/bitops/sched.h>
 #include <asm-generic/bitops/hweight.h>




  reply	other threads:[~2008-12-04 14:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 19:29 Yet more ARM breakage in linux-next Russell King
2008-12-03 20:41 ` Andrew Morton
2008-12-03 23:22   ` Rusty Russell
2008-12-03 23:37     ` Randy Dunlap
2008-12-03 23:46       ` Andrew Morton
2008-12-04  0:10         ` Alan Cox
2008-12-04  0:01       ` David Miller
2008-12-04  0:18         ` Randy Dunlap
2008-12-04  1:27       ` Rusty Russell
2008-12-04  2:56         ` Stephen Hemminger
2008-12-04  0:31     ` Russell King
2008-12-04  3:06       ` Nicolas Pitre
2008-12-04  1:33     ` Mike Frysinger
2008-12-04  2:15       ` Rusty Russell
2008-12-04  3:55         ` Mike Frysinger
2008-12-04  9:18   ` Geert Uytterhoeven
2008-12-04 14:12     ` Rusty Russell [this message]
2008-12-07 21:50       ` Geert Uytterhoeven
2008-12-08  6:20         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812050042.28222.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.