All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ken Chen <kenchen@google.com>, Paul Menage <menage@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] export percpu cpuacct cgroup stats
Date: Fri, 5 Dec 2008 14:52:53 +0100	[thread overview]
Message-ID: <20081205135253.GE27039@elte.hu> (raw)
In-Reply-To: <4938E7C1.9040102@cn.fujitsu.com>


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> Ken Chen wrote:
> > On Thu, Dec 4, 2008 at 11:54 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> >>> +             seq_printf(m, "%llu ", percpu);
> >> Should be:
> >> +               seq_printf(m, "%llu ", (unsigned long long)percpu);
> >>
> >> Otherwsise:
> >> kernel/sched.c: In function 'cpuacct_percpu_seq_read':
> >> kernel/sched.c:9359: warning: format '%llu' expects type 'long long unsigned int',
> >> but argument 3 has type 'u64'
> > 
> > huh, I was just wondering about the type case in cgroup_read_u64()
> > when I was looking at it earlier.  That explains it.  Diff patch
> > attached.
> > 
> 
> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>

Could someone please send the final patch with a final changelog, with 
all fixlets and tags in place please?

Thanks,

	Ingo

  reply	other threads:[~2008-12-05 13:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  4:48 [patch] export percpu cpuacct cgroup stats Ken Chen
2008-12-04  5:34 ` Li Zefan
2008-12-04  9:24   ` Ingo Molnar
2008-12-04 23:02   ` Paul Menage
2008-12-05  7:44     ` Ken Chen
2008-12-05  7:54       ` Li Zefan
2008-12-05  8:30         ` Ken Chen
2008-12-05  8:35           ` Li Zefan
2008-12-05 13:52             ` Ingo Molnar [this message]
2008-12-05 18:16               ` Ken Chen
2008-12-07  7:27                 ` Andrew Morton
2008-12-08 14:33                   ` Ingo Molnar
2008-12-05 18:10         ` Ken Chen
2008-12-08  1:25           ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081205135253.GE27039@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.