All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Ken Chen <kenchen@google.com>
Cc: Paul Menage <menage@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] export percpu cpuacct cgroup stats
Date: Fri, 05 Dec 2008 15:54:04 +0800	[thread overview]
Message-ID: <4938DE1C.6070608@cn.fujitsu.com> (raw)
In-Reply-To: <b040c32a0812042344n75117b68x8de975d12dddf594@mail.gmail.com>

> +static int cpuacct_percpu_seq_read(struct cgroup *cgroup, struct cftype *cft,
> +				   struct seq_file *m)
> +{
> +	struct cpuacct *ca = cgroup_ca(cgroup);
> +	u64 percpu;
> +	int i;
> +
> +	for_each_possible_cpu(i) {
> +		spin_lock_irq(&cpu_rq(i)->lock);
> +		percpu = *percpu_ptr(ca->cpuusage, i);
> +		spin_unlock_irq(&cpu_rq(i)->lock);
> +		seq_printf(m, "%llu ", percpu);

Should be:
+		seq_printf(m, "%llu ", (unsigned long long)percpu);

Otherwsise:
kernel/sched.c: In function ‘cpuacct_percpu_seq_read’:
kernel/sched.c:9359: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 3 has type ‘u64’

> +	}
> +	seq_printf(m, "\n");
> +	return 0;
> +}


  reply	other threads:[~2008-12-05  7:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  4:48 [patch] export percpu cpuacct cgroup stats Ken Chen
2008-12-04  5:34 ` Li Zefan
2008-12-04  9:24   ` Ingo Molnar
2008-12-04 23:02   ` Paul Menage
2008-12-05  7:44     ` Ken Chen
2008-12-05  7:54       ` Li Zefan [this message]
2008-12-05  8:30         ` Ken Chen
2008-12-05  8:35           ` Li Zefan
2008-12-05 13:52             ` Ingo Molnar
2008-12-05 18:16               ` Ken Chen
2008-12-07  7:27                 ` Andrew Morton
2008-12-08 14:33                   ` Ingo Molnar
2008-12-05 18:10         ` Ken Chen
2008-12-08  1:25           ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4938DE1C.6070608@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.