From: Greg KH <gregkh@suse.de>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: "David S. Miller" <davem@davemloft.net>, NETDEV <netdev@vger.kernel.org>
Subject: Re: [PATCH next] staging-p80211: Kill directly reference of netdev->priv
Date: Fri, 5 Dec 2008 07:44:46 -0800 [thread overview]
Message-ID: <20081205154446.GB28030@suse.de> (raw)
In-Reply-To: <4939456D.8010003@cn.fujitsu.com>
On Fri, Dec 05, 2008 at 11:14:53PM +0800, Wang Chen wrote:
> In this driver, netdev's private data is wlandevice_t.
> And the wlandev(type of wlandevice_t) is exist before netdev be allocated.
> So use netdev->ml_priv to point to the private data.
>
> I am not sure whether I should consider the kernel version older than 2.3.38.
> Because in those kernels, netdevice_t is "structure dev" instead of
> "structure net_device" and of course "dev->ml_priv" will cause compile error.
> But before my patch, in function wlan_setup(), there is a ether_setup(net_device)
> which already broke kernels which older than 2.3.38.
Heh, no we only need to support the current mainline kernel with this
driver, no old 2.3.x versions :)
thanks for the patch, I'll queue it up,
greg k-h
next prev parent reply other threads:[~2008-12-05 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 15:14 [PATCH next] staging-p80211: Kill directly reference of netdev->priv Wang Chen
2008-12-05 15:44 ` Greg KH [this message]
2008-12-06 2:28 ` [PATCH next] staging-p80211: Kill directly reference of c Wang Chen
2008-12-06 2:30 ` David Miller
2008-12-06 2:41 ` Greg KH
2008-12-06 3:06 ` David Miller
2008-12-07 7:58 ` [PATCH next] staging-p80211: Kill directly reference of netdev->priv David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205154446.GB28030@suse.de \
--to=gregkh@suse.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.