[lm-sensors] [PATCH 3/4] hwmon: (k8temp) warn about erratum #141

[lm-sensors] [PATCH 3/4] hwmon: (k8temp) warn about erratum #141

[Andreas Herrmann]

Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
 drivers/hwmon/k8temp.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/hwmon/k8temp.c b/drivers/hwmon/k8temp.c
index 894a929..102f3ad 100644
--- a/drivers/hwmon/k8temp.c
+++ b/drivers/hwmon/k8temp.c
@@ -167,15 +167,14 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
 			goto exit;
 		}
 
-		dev_warn(&pdev->dev, "Temperature readouts might be wrong"
-			 " - check erratum #141\n");
-
-		/*
-		 * AMD NPT familys 0fh, i.e. RevF and RevG:
-		 * meaning of SEL_CORE bit is inverted
-		 */
-		if (model >= 0x40)
+		/* AMD NPT familys 0fh, i.e. RevF and RevG */
+		if (model >= 0x40) {
+			/* meaning of SEL_CORE bit is inverted */
 			data->swap_core_select = 1;
+			dev_warn(&pdev->dev, "Temperature readouts might be "
+				 "wrong - check erratum #141\n");
+		}
+
 
 		break;
 	}
-- 
1.6.0.4




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 3/4] hwmon: (k8temp) warn about erratum

[Rudolf Marek]

Hello again,

This is OK lets merge it with 2/4 it belongs there.

Rudolf

Andreas Herrmann napsal(a):
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
>  drivers/hwmon/k8temp.c |   15 +++++++--------
>  1 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hwmon/k8temp.c b/drivers/hwmon/k8temp.c
> index 894a929..102f3ad 100644
> --- a/drivers/hwmon/k8temp.c
> +++ b/drivers/hwmon/k8temp.c
> @@ -167,15 +167,14 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
>  			goto exit;
>  		}
>  
> -		dev_warn(&pdev->dev, "Temperature readouts might be wrong"
> -			 " - check erratum #141\n");
> -
> -		/*
> -		 * AMD NPT familys 0fh, i.e. RevF and RevG:
> -		 * meaning of SEL_CORE bit is inverted
> -		 */
> -		if (model >= 0x40)
> +		/* AMD NPT familys 0fh, i.e. RevF and RevG */
> +		if (model >= 0x40) {
> +			/* meaning of SEL_CORE bit is inverted */
>  			data->swap_core_select = 1;
> +			dev_warn(&pdev->dev, "Temperature readouts might be "
> +				 "wrong - check erratum #141\n");
> +		}
> +
>  
>  		break;
>  	}

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 3/4] hwmon: (k8temp) warn about erratum

[Andreas Herrmann]

On Tue, Dec 09, 2008 at 11:32:54PM +0100, Rudolf Marek wrote:
> Hello again,
>
> This is OK lets merge it with 2/4 it belongs there.

Ok.

I just wait what will happen to patch 1 and then will
create new patches.


Regards,

Andreas



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors