From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] use sparc64 version of prom/printf.c
Date: Sun, 07 Dec 2008 19:40:27 +0000 [thread overview]
Message-ID: <20081207194027.GA20726@uranus.ravnborg.org> (raw)
In-Reply-To: <493C1616.6080206@earthlink.net>
On Sun, Dec 07, 2008 at 08:19:21PM +0100, Sam Ravnborg wrote:
> Hi Robert.
>
> On Sun, Dec 07, 2008 at 01:29:42PM -0500, Robert Reif wrote:
> > Use sparc64 version of prom/printf.c.
> >
> > The only differences for sparc32 is that prom_printf is no longer
> > exported for modules which should be OK.
>
> cyber200fb uses prom_prinf and can be built as a module.
> >From Kconfig:
>
> config FB_CYBER2000
> tristate "CyberPro 2000/2010/5000 support"
> depends on FB && PCI && (BROKEN || !SPARC64)
>
> So it looks to me we should keep the EXPORT.
And a test bult with your patch confirmed this:
MODPOST 5 modules
ERROR: "prom_printf" [drivers/video/cyber2000fb.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
Please redo your patch with the EXPORT kept.
I cannot see that it hurts sparc64 so no need to do it conditionally.
Sam
next prev parent reply other threads:[~2008-12-07 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 18:29 [PATCH] use sparc64 version of prom/printf.c Robert Reif
2008-12-07 19:19 ` Sam Ravnborg
2008-12-07 19:40 ` Sam Ravnborg [this message]
2008-12-08 1:53 ` Robert Reif
2008-12-08 7:42 ` David Miller
2008-12-08 9:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081207194027.GA20726@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.