[PATCH 1/1] fs: fix warning message with inserting a single space

[PATCH 1/1] fs: fix warning message with inserting a single space

[Hiroshi DOYU]

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 fs/libfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/libfs.c b/fs/libfs.c
index 1add676..8e6fa43 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -453,7 +453,7 @@ int simple_fill_super(struct super_block *s, int magic, struct tree_descr *files
 
 		/* warn if it tries to conflict with the root inode */
 		if (unlikely(i == 1))
-			printk(KERN_WARNING "%s: %s passed in a files array"
+			printk(KERN_WARNING "%s: %s passed in a files array "
 				"with an index of 1!\n", __func__,
 				s->s_type->name);
 
-- 
1.6.0.4.836.gd5cb

Re: [PATCH 1/1] fs: fix warning message with inserting a single space

[Nick Andrew]

On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
> -			printk(KERN_WARNING "%s: %s passed in a files array"
> +			printk(KERN_WARNING "%s: %s passed in a files array "
>  				"with an index of 1!\n", __func__,
>  				s->s_type->name);

Yep. These look like the same kind of thing:

arch/powerpc/platforms/cell/iommu.c +1109
                                pr_debug("iommu: hash window doesn't fit in"
                                         "real DMA window\n");

arch/powerpc/platforms/cell/spider-pci.c +138
                pr_err("SPIDERPCI-IOWA:"
                       "Can't allocate struct spiderpci_iowa_private");

(space after a colon?)

arch/x86/kernel/microcode_intel.c +374
                        printk(KERN_ERR "microcode: error!"
                                        "Bad data in microcode data file\n");

arch/x86/kernel/microcode_amd.c +411
        printk(KERN_WARNING "microcode: AMD microcode update via /dev/cpu/microcode"
                        "is not supported\n");

arch/x86/kernel/pci-dma.c +303
                printk(KERN_INFO "PCI: VIA PCI bridge detected."
                                 "Disabling DAC.\n");

arch/x86/kernel/smpboot.c +412
                printk(KERN_WARNING "WARNING: SMP operation may be unreliable"
                                    "with B stepping processors.\n");

arch/x86/kernel/smpboot.c +420
                printk(KERN_INFO "WARNING: This combination of AMD"
                        "processors is not suitable for SMP.\n");

arch/x86/kernel/smpboot.c +1089
                printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
                                    "by the BIOS.\n", hard_smp_processor_id());

arch/x86/kernel/smpboot.c +1127
                printk(KERN_ERR "... forcing use of dummy APIC emulation."
                                "(tell your hw vendor)\n");

arch/x86/mm/init_32.c +668
                        printk(KERN_WARNING "Warning only 4GB will be used."
                                "Use a HIGHMEM64G enabled kernel.\n");

arch/arm/common/dmabounce.c +510
                         "Never registered with dmabounce but attempting"
                         "to unregister!\n");

arch/arm/plat-omap/dma.c +1843
                        printk(KERN_WARNING "IRQ %04x for non-allocated DMA"
                                        "channel %d\n", status, ch);

arch/arm/plat-omap/mcbsp.c +874
                dev_err(&pdev->dev, "McBSP device initialized without"
                                "platform data\n");

arch/arm/mach-s3c2412/mach-jive.c +255
                printk(KERN_ERR "Unknown mtd set %ld specified,"
                       "using default.", set);

arch/arm/mach-pxa/trizeps4.c +354
                printk(KERN_ERR "trizeps4_mci_init: MMC/SD: can't request"
                                                "MMC card detect IRQ\n");

arch/arm/mach-pxa/mioa701.c +651
        printk(KERN_CRIT "Unregistering mioa701 suspend will hang next"
               "resume !!!\n");

arch/ia64/sn/kernel/io_common.c +354
                printk(KERN_WARNING "on node %d but only %d nodes online."
                       "Association set to undetermined.\n",

arch/ia64/kernel/kprobes.c +249
                        printk(KERN_WARNING "Kprobes on IP-Relative"
                                        "Predict is not supported\n");

Nick.

Re: [PATCH 1/1] fs: fix warning message with inserting a single space

[Artem Bityutskiy]

Nick Andrew wrote:
> On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
>> -			printk(KERN_WARNING "%s: %s passed in a files array"
>> +			printk(KERN_WARNING "%s: %s passed in a files array "
>>  				"with an index of 1!\n", __func__,
>>  				s->s_type->name);
> 
> Yep. These look like the same kind of thing:
> 
> arch/powerpc/platforms/cell/iommu.c +1109
>                                 pr_debug("iommu: hash window doesn't fit in"
>                                          "real DMA window\n");

Do we have such kind of check in checkpatch.pl? Would be useful.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: [PATCH 1/1] fs: fix warning message with inserting a single space

[Artem Bityutskiy]

Artem Bityutskiy wrote:
> Nick Andrew wrote:
>> On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
>>> -            printk(KERN_WARNING "%s: %s passed in a files array"
>>> +            printk(KERN_WARNING "%s: %s passed in a files array "
>>>                  "with an index of 1!\n", __func__,
>>>                  s->s_type->name);
>>
>> Yep. These look like the same kind of thing:
>>
>> arch/powerpc/platforms/cell/iommu.c +1109
>>                                 pr_debug("iommu: hash window doesn't 
>> fit in"
>>                                          "real DMA window\n");
> 
> Do we have such kind of check in checkpatch.pl? Would be useful.

Although I guess it is difficult to formalize this.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

Re: [PATCH 1/1] fs: fix warning message with inserting a single space

[Oliver Neukum]

Am Montag, 8. Dezember 2008 14:16:05 schrieb Artem Bityutskiy:
> Nick Andrew wrote:
> > On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
> >> -			printk(KERN_WARNING "%s: %s passed in a files array"
> >> +			printk(KERN_WARNING "%s: %s passed in a files array "
> >>  				"with an index of 1!\n", __func__,
> >>  				s->s_type->name);
> > 
> > Yep. These look like the same kind of thing:
> > 
> > arch/powerpc/platforms/cell/iommu.c +1109
> >                                 pr_debug("iommu: hash window doesn't fit in"
> >                                          "real DMA window\n");
> 
> Do we have such kind of check in checkpatch.pl? Would be useful.

No, it wouldn't. A kernel message should be grepable. So, when in doubt,
screw the screen width limit. Don't make making ungreppable messages
easier.

	Regards
		Oliver