* [PATCH] mac80211/cfg80211: check endianness in sparse runs
@ 2008-12-09 11:39 Johannes Berg
2008-12-09 12:12 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2008-12-09 11:39 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Sam Ravnborg
Make sure sparse checks endianness when run on mac80211/cfg80211.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
It doesn't hurt setting this for the compiler as well.
net/mac80211/Makefile | 2 ++
net/wireless/Makefile | 2 ++
2 files changed, 4 insertions(+)
--- everything.orig/net/mac80211/Makefile 2008-12-08 21:53:02.000000000 +0100
+++ everything/net/mac80211/Makefile 2008-12-08 21:54:02.000000000 +0100
@@ -46,3 +46,5 @@ rc80211_minstrel-$(CONFIG_MAC80211_DEBUG
mac80211-$(CONFIG_MAC80211_RC_PID) += $(rc80211_pid-y)
mac80211-$(CONFIG_MAC80211_RC_MINSTREL) += $(rc80211_minstrel-y)
+
+ccflags-y += -D__CHECK_ENDIAN__
--- everything.orig/net/wireless/Makefile 2008-12-08 21:53:02.000000000 +0100
+++ everything/net/wireless/Makefile 2008-12-08 21:54:02.000000000 +0100
@@ -8,3 +8,5 @@ obj-$(CONFIG_LIB80211_CRYPT_TKIP) += lib
cfg80211-y += core.o sysfs.o radiotap.o util.o reg.o
cfg80211-$(CONFIG_WIRELESS_EXT) += wext-compat.o
cfg80211-$(CONFIG_NL80211) += nl80211.o
+
+ccflags-y += -D__CHECK_ENDIAN__
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211/cfg80211: check endianness in sparse runs
2008-12-09 11:39 [PATCH] mac80211/cfg80211: check endianness in sparse runs Johannes Berg
@ 2008-12-09 12:12 ` Sam Ravnborg
2008-12-09 12:14 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2008-12-09 12:12 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
On Tue, Dec 09, 2008 at 12:39:52PM +0100, Johannes Berg wrote:
> Make sure sparse checks endianness when run on mac80211/cfg80211.
>
How far are we from being able to do this kernel wide?
Some effort has been put into lower the noise level I think.
So I prefer to see it generally enabled but if this is too soon
then I'm fine with this patch.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211/cfg80211: check endianness in sparse runs
2008-12-09 12:12 ` Sam Ravnborg
@ 2008-12-09 12:14 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2008-12-09 12:14 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: John Linville, linux-wireless, Harvey Harrison
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Tue, 2008-12-09 at 13:12 +0100, Sam Ravnborg wrote:
> On Tue, Dec 09, 2008 at 12:39:52PM +0100, Johannes Berg wrote:
> > Make sure sparse checks endianness when run on mac80211/cfg80211.
> >
>
> How far are we from being able to do this kernel wide?
> Some effort has been put into lower the noise level I think.
Not sure, I think Harvey has been working on this, Harvey?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-09 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-09 11:39 [PATCH] mac80211/cfg80211: check endianness in sparse runs Johannes Berg
2008-12-09 12:12 ` Sam Ravnborg
2008-12-09 12:14 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.