All of lore.kernel.org
 help / color / mirror / Atom feed
* Minor bug in "ip addr" output
@ 2008-12-09 23:33 Benedikt Gollatz
  0 siblings, 0 replies; only message in thread
From: Benedikt Gollatz @ 2008-12-09 23:33 UTC (permalink / raw)
  To: netdev

There is a minor problem in iproute2 regarding the output of "ip -6 addr". 
Preferred lifetimes of IPv6 prefixes are printed as unsigned integers even 
though they may become negative (for deprecated prefixes).

As I've argued in <http://bugzilla.kernel.org/show_bug.cgi?id=10880>, I think 
this is partly because of an inconsistency in the kernel APIs, but since 
nobody seemed interested, I guess it has to be dealt with by application 
developers.

The following patch fixes the problem.

--- a/ip/ipaddress.c	2008-07-25 22:46:07.000000000 +0200
+++ b/ip/ipaddress.c	2008-12-08 03:29:27.000000000 +0100
@@ -360,4 +360,5 @@
 	struct ifaddrmsg *ifa = NLMSG_DATA(n);
 	int len = n->nlmsg_len;
+	int deprecated = 0;
 	struct rtattr * rta_tb[IFA_MAX+1];
 	char abuf[256];
@@ -489,4 +490,5 @@
 	if (ifa->ifa_flags&IFA_F_DEPRECATED) {
 		ifa->ifa_flags &= ~IFA_F_DEPRECATED;
+		deprecated = 1;
 		fprintf(fp, "deprecated ");
 	}
@@ -517,7 +519,12 @@
 		if (ci->ifa_prefered == INFINITY_LIFE_TIME)
 			sprintf(buf+strlen(buf), " preferred_lft forever");
-		else
-			sprintf(buf+strlen(buf), " preferred_lft %usec",
-				ci->ifa_prefered);
+		else {
+			if (deprecated)
+				sprintf(buf+strlen(buf), " preferred_lft %dsec",
+					ci->ifa_prefered);
+			else
+				sprintf(buf+strlen(buf), " preferred_lft %usec",
+					ci->ifa_prefered);
+		}
 		fprintf(fp, "       %s", buf);
 	}



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-12-10  0:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-09 23:33 Minor bug in "ip addr" output Benedikt Gollatz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.