All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Fix LSF default inconsistency
Date: Thu, 11 Dec 2008 11:58:44 +0100	[thread overview]
Message-ID: <20081211115844.1b1dbf49@hyperion.delvare> (raw)
In-Reply-To: <20081211104109.GF23742@kernel.dk>

On Thu, 11 Dec 2008 11:41:10 +0100, Jens Axboe wrote:
> On Thu, Dec 11 2008, Jean Delvare wrote:
> > Configuration option LSF has a default which contradicts its help
> > text. The help text says "if unsure, say Y" but there is no explicit
> > default, and the default default is N.
> > 
> > This inconsistency was introduced by commit
> > 88b9adb073b7a69a54b1b14423103bc24587ebdc. According to the commit
> > message, we want users to enable this option, so it should default to
> > Y.
> 
> I wonder if we just shouldn't get rid of this option and just have the
> single CONFIG_LBD option control both of these. If you set CONFIG_LBD,
> you probably want large files as well. And CONFIG_LSF without CONFIG_LBD
> doesn't make a lot of sense.
> 
> Would anyone object to such a change?

No objection from me, getting rid of configuration options almost
always gets my vote :)

-- 
Jean Delvare

  reply	other threads:[~2008-12-11 10:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 10:16 [PATCH] block: Fix LSF default inconsistency Jean Delvare
2008-12-11 10:41 ` Jens Axboe
2008-12-11 10:58   ` Jean Delvare [this message]
2008-12-11 11:08     ` Jens Axboe
2008-12-11 11:33       ` KOSAKI Motohiro
2008-12-11 11:36         ` Jens Axboe
2008-12-11 11:44           ` KOSAKI Motohiro
2008-12-12  7:58             ` Jens Axboe
2008-12-12 13:50               ` Rik van Riel
2008-12-12 15:11                 ` KOSAKI Motohiro
2008-12-12 16:01                   ` Hugh Dickins
2008-12-12 16:35                     ` Rik van Riel
2008-12-12 17:37                       ` Hugh Dickins
2008-12-12 18:00                         ` Rik van Riel
2008-12-12 19:26                           ` Hugh Dickins
2008-12-11 12:44       ` Jean Delvare
2008-12-11 12:50         ` Jens Axboe
2008-12-12  7:48           ` Jean Delvare
2008-12-12  7:54             ` Jens Axboe
2008-12-12  9:41               ` Jean Delvare
2008-12-12 18:18                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081211115844.1b1dbf49@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.