All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Jean Delvare <khali@linux-fr.org>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Fix LSF default inconsistency
Date: Fri, 12 Dec 2008 11:35:32 -0500	[thread overview]
Message-ID: <494292D4.6090302@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812121559220.19722@blonde.anvils>

Hugh Dickins wrote:
> On Sat, 13 Dec 2008, KOSAKI Motohiro wrote:
>   
>> To move mlocked file cache page to unevictable list is useful although
>> swapless embedded device.
>>     
>
> Yes, I don't understand why Rik suggested CONFIG_SWAP for it either.
On swapless systems (with CONFIG_SWAP=n), we never scan
the anon lists, so we do not need to split out the mlocked pages from
the anon pages.

On a system with swap, we want to split out the mlocked pages
so that scan balancing always works right.  So whenever
CONFIG_SWAP is on, we want CONFIG_UNEVICTABLE_LRU
to be on as well.

That means we can replace CONFIG_UNEVICTABLE_LRU
with CONFIG_SWAP throughout the code, and get a kernel
with the desired behaviour either way.



  reply	other threads:[~2008-12-12 16:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 10:16 [PATCH] block: Fix LSF default inconsistency Jean Delvare
2008-12-11 10:41 ` Jens Axboe
2008-12-11 10:58   ` Jean Delvare
2008-12-11 11:08     ` Jens Axboe
2008-12-11 11:33       ` KOSAKI Motohiro
2008-12-11 11:36         ` Jens Axboe
2008-12-11 11:44           ` KOSAKI Motohiro
2008-12-12  7:58             ` Jens Axboe
2008-12-12 13:50               ` Rik van Riel
2008-12-12 15:11                 ` KOSAKI Motohiro
2008-12-12 16:01                   ` Hugh Dickins
2008-12-12 16:35                     ` Rik van Riel [this message]
2008-12-12 17:37                       ` Hugh Dickins
2008-12-12 18:00                         ` Rik van Riel
2008-12-12 19:26                           ` Hugh Dickins
2008-12-11 12:44       ` Jean Delvare
2008-12-11 12:50         ` Jens Axboe
2008-12-12  7:48           ` Jean Delvare
2008-12-12  7:54             ` Jens Axboe
2008-12-12  9:41               ` Jean Delvare
2008-12-12 18:18                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494292D4.6090302@redhat.com \
    --to=riel@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=hugh@veritas.com \
    --cc=jens.axboe@oracle.com \
    --cc=khali@linux-fr.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.