All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change
Date: Thu, 11 Dec 2008 12:39:40 +0000	[thread overview]
Message-ID: <200812111239.41509.paul@codesourcery.com> (raw)
In-Reply-To: <4940FFBF.1060308@eu.citrix.com>

> void qemu_console_resize(DisplayState *ds, int width, int height, int bpp,
>                          int linesize, uint8_t *data)
> {
>     TextConsole *s = get_graphic_console();
>     s->g_width = width;
>     s->g_height = height;
>     if (is_graphic_console()) {
>         if (data && (bpp == 16 || bpp == 32)) {
>             qemu_freeDisplaySurface(ds->surface);
>             ds->surface = qemu_createDisplaySurfaceFrom(width, height, bpp,
> linesize, data); } else {
>             ds->surface = qemu_resizeDisplaySurface(ds->surface, width,
> height, 32, 4 * width); }
>         dpy_resize(ds);
>     }
> }

It feels wrong to be modifying the surface here. We already have to recreate 
the surface when we switch consoles, so why can't we use the same code for a 
resize?

Paul

  reply	other threads:[~2008-12-11 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 17:47 [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change Stefano Stabellini
2008-11-26 18:40 ` Paul Brook
2008-11-26 19:08   ` Stefano Stabellini
2008-11-27 23:42     ` Anthony Liguori
2008-11-28  0:29       ` Paul Brook
2008-12-02 19:35         ` Anthony Liguori
2008-12-11 11:55           ` Stefano Stabellini
2008-12-11 12:39             ` Paul Brook [this message]
2008-12-11 15:22               ` Stefano Stabellini
2008-12-11 15:29                 ` Paul Brook
2008-12-11 15:37                   ` Stefano Stabellini
2008-12-11 15:45                     ` Paul Brook
2008-11-28 11:03       ` Stefano Stabellini
2008-12-02 19:33 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812111239.41509.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.