Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

Anthony Liguori wrote:

> Stefano Stabellini wrote:
>> Paul Brook wrote:
>>
>>  
>>>> - do not use is_active_console, use is_graphic_console instead.
>>>>       
>>> This is wrong. There may be multiple graphic consoles.
>>>     
>>
>> I thought we wanted to move to a model in which a DisplayState
>> corresponds to a single QEMUConsole and a single graphic device.
>> This is the reason for Anthony to ask me this update, if I am not
>> mistaken.
>>   
> 
> I need to look more closely at the patches (and I will tomorrow), but to
> me, the use of is_active_console or is_graphics_console is a red
> herring.  Nothing should never need to know whether it's the "active"
> console.  Such a concept simply shouldn't exist.
> 
> I think this is Paul's point about multiple graphics consoles.  If you
> have two graphics consoles, than the concept of active console doesn't
> make very much sense.  Is that what you were thinking Paul?


I can easily remove it, at the price of changing qemu_console_resize in:

void qemu_console_resize(DisplayState *ds, int width, int height, int bpp,
                         int linesize, uint8_t *data);

>>>> This patch changes the graphical_console_init function to return an
>>>> allocated DisplayState instead of a QEMUConsole.
>>>>       
>>> You should also remove QEMUConsole.
>>>     
>>
>> I removed QEMUConsole from the graphic devices, I am not going to
>> completely get rid of it because it is currently needed by text consoles
>> and to multiplex multiple consoles.
>>   
> 
> QEMUConsole is just a typedef right now.  Could you remove the typedef? 
> It should become unused after your patch.
> 

I think I could remove it now, without even a single compile warning :)