Calling an I2C camera sensor with SMBUS API?

Calling an I2C camera sensor with SMBUS API?

[Aguirre Rodriguez, Sergio Alberto]

Hi,

Some days back, Vaibhav Hiremath submitted patches to linux-omap and video4linux trees for an I2C video codec chip, and he was suggested to use SMBUS API instead of manually constructing i2c messages and sending using i2c_transfer API.

So I attempted to do the same for a camera sensor I've been working on.

But one thing I noticed is that my sensor needs to access 16-bit register addresses in the device, and I saw in SMBUS spec 2.0 that the equivalent thing (SMBUS commands) are only 8-bit length.

So, should this automatically discard using SMBUS api for my case, or am I missing something else? (like a SMBUS 16-bit expansion or so)

Regards,
Sergio

Re: Calling an I2C camera sensor with SMBUS API?

[Jean Delvare]

Hi Sergio,

On Thu, 11 Dec 2008 17:55:26 -0600, Aguirre Rodriguez, Sergio Alberto wrote:
> Some days back, Vaibhav Hiremath submitted patches to linux-omap and
> video4linux trees for an I2C video codec chip, and he was suggested to
> use SMBUS API instead of manually constructing i2c messages and sending
> using i2c_transfer API.
> 
> So I attempted to do the same for a camera sensor I've been working on.
> 
> But one thing I noticed is that my sensor needs to access 16-bit register
> addresses in the device, and I saw in SMBUS spec 2.0 that the equivalent
> thing (SMBUS commands) are only 8-bit length.
> 
> So, should this automatically discard using SMBUS api for my case, or am
> I missing something else? (like a SMBUS 16-bit expansion or so)

You are correct, SMBus messaging implies an 8-bit command field (which
is most frequently used for register addressing.) There are no 16-bit
command variants. For writes, we can cheat because there is no
direction change between the address and the data, but for reads
there's simply nothing we can do to work around this limitation. So,
unless your device is write-only, you indeed can't use the SMBus-level
API for 16-bit register addresses and you have to stick to the
I2C-level API.

-- 
Jean Delvare

Re: Calling an I2C camera sensor with SMBUS API?

[David Brownell]

On Friday 12 December 2008, Jean Delvare wrote:
> > So, should this automatically discard using SMBUS api for my case, or am
> > I missing something else? (like a SMBUS 16-bit expansion or so)
> 
> You are correct, SMBus messaging implies an 8-bit command field (which
> is most frequently used for register addressing.) There are no 16-bit
> command variants.

How about the "proc call" ... 16 bits to the slave, 16 bits back?
That would be like a "read 16 bit register with 16 bit address".

ISTR we had that a routine supporting that at one point (and the
infrastructure for it is still there, emulation and all) but it was
removed because it was still seeking its first use.


> For writes, we can cheat because there is no 
> direction change between the address and the data,

Cheat how?


>	 but for reads
> there's simply nothing we can do to work around this limitation. So,
> unless your device is write-only, you indeed can't use the SMBus-level
> API for 16-bit register addresses and you have to stick to the
> I2C-level API.

If addresses and data are both 16 bits, I only see how to do reads,
not writes, within the scope of the SMBus calls.  Of course, SMBus
also supports byte and (small-)counted-array data too.

- Dave

 
> -- 
> Jean Delvare
> 
> 

Re: Calling an I2C camera sensor with SMBUS API?

[Jean Delvare]

On Fri, 12 Dec 2008 08:46:48 -0800, David Brownell wrote:
> On Friday 12 December 2008, Jean Delvare wrote:
> > > So, should this automatically discard using SMBUS api for my case, or am
> > > I missing something else? (like a SMBUS 16-bit expansion or so)
> > 
> > You are correct, SMBus messaging implies an 8-bit command field (which
> > is most frequently used for register addressing.) There are no 16-bit
> > command variants.
> 
> How about the "proc call" ... 16 bits to the slave, 16 bits back?
> That would be like a "read 16 bit register with 16 bit address".

No, the SMBus process call is 8 bits command, 16 bits data from master
to slave, then 16 bits data from slave to master. So total 24 bits from
master to the slave, not 16.

> ISTR we had that a routine supporting that at one point (and the
> infrastructure for it is still there, emulation and all) but it was
> removed because it was still seeking its first use.

Actually i2c_smbus_process_call() is back in 2.6.28 already, for an
upcoming driver which needs it. But it doesn't help there.

> > For writes, we can cheat because there is no 
> > direction change between the address and the data,
> 
> Cheat how?

You can use SMBus write word as 16 bits for register address and 8 bits
for data, even though it is originally designed as 8 bits for register
address and 16 bits for data. More generally, you can use I2C block
writes (which are often supported by SMBus controllers up to 32 bytes)
by simply passing the 8 extra register address bits as the first data
byte, and all other data bytes are shifted by one. This allows for up
to 31 data bytes to be written.

> >	 but for reads
> > there's simply nothing we can do to work around this limitation. So,
> > unless your device is write-only, you indeed can't use the SMBus-level
> > API for 16-bit register addresses and you have to stick to the
> > I2C-level API.
> 
> If addresses and data are both 16 bits, I only see how to do reads,
> not writes, within the scope of the SMBus calls.  Of course, SMBus
> also supports byte and (small-)counted-array data too.

-- 
Jean Delvare

Calling an I2C camera sensor with SMBUS API?

[Aguirre Rodriguez, Sergio Alberto]

Hi,

Some days back, Vaibhav Hiremat submitted patches for an I2C chip, and somebody (I think David Brownell) suggested to use SMBUS API instead of manually constructing i2c messages and sending using i2c_transfer API.

So I attempted to do the same for a camera sensor I've been working on.

But one thing I noticed is that my sensor needs to access 16-bit register addresses in the device, and I saw in SMBUS spec 2.0 that the equivalent thing (SMBUS commands) are only 8-bit length.

So, should this automatically discard using SMBUS api for my case, or am I missing something else? (like a SMBUS 16-bit expansion or so)

Regards,
Sergio

Re: Calling an I2C camera sensor with SMBUS API?

[David Brownell]

On Thursday 11 December 2008, Aguirre Rodriguez, Sergio Alberto wrote:
> But one thing I noticed is that my sensor needs to access 16-bit
> register addresses in the device, and I saw in SMBUS spec 2.0 that
> the equivalent thing (SMBUS commands) are only 8-bit length.  
> 
> So, should this automatically discard using SMBUS api for my case,
> or am I missing something else? (like a SMBUS 16-bit expansion or so) 

There's the "proc call" which gives 16 bits in each direction;
I think the Linux call for that got removed because it had no
users, but could be restored if needed.

Probably best to take this question up on the I2C list.

- Dave

RE: Calling an I2C camera sensor with SMBUS API?

[Aguirre Rodriguez, Sergio Alberto]

> From: David Brownell [mailto:david-b@pacbell.net]
> On Thursday 11 December 2008, Aguirre Rodriguez, Sergio Alberto wrote:
> > But one thing I noticed is that my sensor needs to access 16-bit
> > register addresses in the device, and I saw in SMBUS spec 2.0 that
> > the equivalent thing (SMBUS commands) are only 8-bit length.
> >
> > So, should this automatically discard using SMBUS api for my case,
> > or am I missing something else? (like a SMBUS 16-bit expansion or so)
> 
> There's the "proc call" which gives 16 bits in each direction;
> I think the Linux call for that got removed because it had no
> users, but could be restored if needed.
> 
> Probably best to take this question up on the I2C list.

Ok, thanks. Just did that. (with both of you guys on CC)

Regards,
Sergio