* [PATCH] net: eliminate warning from NETIF_F_UFO on bridge
@ 2008-12-12 18:27 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2008-12-12 18:27 UTC (permalink / raw)
To: David Miller; +Cc: stable, netdev
The bridge device always causes a warning because when it is first created
it has the no checksum flag set along with all the segmentation/fragmentation
offload bits. The code in register_netdevice incorrectly checks for only
hardware checksum bit and ignores no checksum bit.
Similar code is already in 2.6.28:
commit b63365a2d60268a3988285d6c3c6003d7066f93a
net: Fix disjunct computation of netdev features
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Patch against 2.6.27.y
--- a/net/core/dev.c 2008-12-09 09:52:03.226334984 -0800
+++ b/net/core/dev.c 2008-12-09 09:53:15.527751814 -0800
@@ -3990,7 +3990,7 @@ int register_netdevice(struct net_device
dev->features &= ~NETIF_F_TSO;
}
if (dev->features & NETIF_F_UFO) {
- if (!(dev->features & NETIF_F_HW_CSUM)) {
+ if (!(dev->features & NETIF_F_GEN_CSUM)) {
printk(KERN_ERR "%s: Dropping NETIF_F_UFO since no "
"NETIF_F_HW_CSUM feature.\n",
dev->name);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-12 18:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-12 18:27 [PATCH] net: eliminate warning from NETIF_F_UFO on bridge Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.