From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
Date: Mon, 15 Dec 2008 08:28:30 +0100 [thread overview]
Message-ID: <20081215072830.GQ23742@kernel.dk> (raw)
In-Reply-To: <20081214124508U.fujita.tomonori@lab.ntt.co.jp>
On Sun, Dec 14 2008, FUJITA Tomonori wrote:
> This is a resend of:
>
> http://marc.info/?l=linux-kernel&m=122482703616607&w=2
>
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
>
> The block layer dropped the virtual merge feature
> (b8b3e16cfe6435d961f6aaebcfd52a1ff2a988c5). BIO_VMERGE_BOUNDARY
> definition is meaningless now (For POWER, BIO_VMERGE_BOUNDARY has been
> meaningless for a long time since POWER disables the virtual merge
> feature).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
> ---
> arch/powerpc/include/asm/io.h | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
> index 08266d2..494cd8b 100644
> --- a/arch/powerpc/include/asm/io.h
> +++ b/arch/powerpc/include/asm/io.h
> @@ -713,13 +713,6 @@ static inline void * phys_to_virt(unsigned long address)
> */
> #define page_to_phys(page) ((phys_addr_t)page_to_pfn(page) << PAGE_SHIFT)
>
> -/* We do NOT want virtual merging, it would put too much pressure on
> - * our iommu allocator. Instead, we want drivers to be smart enough
> - * to coalesce sglists that happen to have been mapped in a contiguous
> - * way by the iommu
> - */
> -#define BIO_VMERGE_BOUNDARY 0
> -
> /*
> * 32 bits still uses virt_to_bus() for it's implementation of DMA
> * mappings se we have to keep it defined here. We also have some old
> --
> 1.5.5.GIT
>
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
Date: Mon, 15 Dec 2008 08:28:30 +0100 [thread overview]
Message-ID: <20081215072830.GQ23742@kernel.dk> (raw)
In-Reply-To: <20081214124508U.fujita.tomonori@lab.ntt.co.jp>
On Sun, Dec 14 2008, FUJITA Tomonori wrote:
> This is a resend of:
>
> http://marc.info/?l=linux-kernel&m=122482703616607&w=2
>
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition
>
> The block layer dropped the virtual merge feature
> (b8b3e16cfe6435d961f6aaebcfd52a1ff2a988c5). BIO_VMERGE_BOUNDARY
> definition is meaningless now (For POWER, BIO_VMERGE_BOUNDARY has been
> meaningless for a long time since POWER disables the virtual merge
> feature).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
> ---
> arch/powerpc/include/asm/io.h | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
> index 08266d2..494cd8b 100644
> --- a/arch/powerpc/include/asm/io.h
> +++ b/arch/powerpc/include/asm/io.h
> @@ -713,13 +713,6 @@ static inline void * phys_to_virt(unsigned long address)
> */
> #define page_to_phys(page) ((phys_addr_t)page_to_pfn(page) << PAGE_SHIFT)
>
> -/* We do NOT want virtual merging, it would put too much pressure on
> - * our iommu allocator. Instead, we want drivers to be smart enough
> - * to coalesce sglists that happen to have been mapped in a contiguous
> - * way by the iommu
> - */
> -#define BIO_VMERGE_BOUNDARY 0
> -
> /*
> * 32 bits still uses virt_to_bus() for it's implementation of DMA
> * mappings se we have to keep it defined here. We also have some old
> --
> 1.5.5.GIT
>
--
Jens Axboe
next prev parent reply other threads:[~2008-12-15 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-14 3:44 [RESEND] [PATCH] powerpc: remove dead BIO_VMERGE_BOUNDARY definition FUJITA Tomonori
2008-12-14 3:44 ` FUJITA Tomonori
2008-12-15 7:28 ` Jens Axboe [this message]
2008-12-15 7:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215072830.GQ23742@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.