From: Jean Delvare <khali@linux-fr.org>
To: Samuel Ortiz <sameo@openedhand.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Rapoport <mike@compulab.co.il>,
Eric Miao <eric.miao@marvell.com>, Liam Girdwood <lrg@kernel.org>
Subject: [PATCH] da903x: Fix section mismatch
Date: Mon, 15 Dec 2008 11:28:05 +0100 [thread overview]
Message-ID: <20081215112805.41b6cf13@hyperion.delvare> (raw)
da903x_remove_subdevs() can be called in case of device initialization
error, so it shouldn't be tagged __devexit.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Mike Rapoport <mike@compulab.co.il>
Cc: Eric Miao <eric.miao@marvell.com>
Cc: Samuel Ortiz <sameo@openedhand.com>
Cc: Liam Girdwood <lrg@kernel.org>
---
drivers/mfd/da903x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.28-rc8.orig/drivers/mfd/da903x.c 2008-11-21 10:59:44.000000000 +0100
+++ linux-2.6.28-rc8/drivers/mfd/da903x.c 2008-12-15 11:19:30.000000000 +0100
@@ -435,13 +435,13 @@ static const struct i2c_device_id da903x
};
MODULE_DEVICE_TABLE(i2c, da903x_id_table);
-static int __devexit __remove_subdev(struct device *dev, void *unused)
+static int __remove_subdev(struct device *dev, void *unused)
{
platform_device_unregister(to_platform_device(dev));
return 0;
}
-static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
+static int da903x_remove_subdevs(struct da903x_chip *chip)
{
return device_for_each_child(chip->dev, NULL, __remove_subdev);
}
--
Jean Delvare
next reply other threads:[~2008-12-15 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 10:28 Jean Delvare [this message]
2008-12-15 10:45 ` [PATCH] da903x: Fix section mismatch Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215112805.41b6cf13@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=eric.miao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
--cc=mike@compulab.co.il \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.