* [PATCH] da903x: Fix section mismatch
@ 2008-12-15 10:28 Jean Delvare
2008-12-15 10:45 ` Eric Miao
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2008-12-15 10:28 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: LKML, Mike Rapoport, Eric Miao, Liam Girdwood
da903x_remove_subdevs() can be called in case of device initialization
error, so it shouldn't be tagged __devexit.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Mike Rapoport <mike@compulab.co.il>
Cc: Eric Miao <eric.miao@marvell.com>
Cc: Samuel Ortiz <sameo@openedhand.com>
Cc: Liam Girdwood <lrg@kernel.org>
---
drivers/mfd/da903x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.28-rc8.orig/drivers/mfd/da903x.c 2008-11-21 10:59:44.000000000 +0100
+++ linux-2.6.28-rc8/drivers/mfd/da903x.c 2008-12-15 11:19:30.000000000 +0100
@@ -435,13 +435,13 @@ static const struct i2c_device_id da903x
};
MODULE_DEVICE_TABLE(i2c, da903x_id_table);
-static int __devexit __remove_subdev(struct device *dev, void *unused)
+static int __remove_subdev(struct device *dev, void *unused)
{
platform_device_unregister(to_platform_device(dev));
return 0;
}
-static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
+static int da903x_remove_subdevs(struct da903x_chip *chip)
{
return device_for_each_child(chip->dev, NULL, __remove_subdev);
}
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] da903x: Fix section mismatch
2008-12-15 10:28 [PATCH] da903x: Fix section mismatch Jean Delvare
@ 2008-12-15 10:45 ` Eric Miao
0 siblings, 0 replies; 2+ messages in thread
From: Eric Miao @ 2008-12-15 10:45 UTC (permalink / raw)
To: Jean Delvare; +Cc: Samuel Ortiz, LKML, Mike Rapoport, Eric Miao, Liam Girdwood
On Mon, Dec 15, 2008 at 6:28 PM, Jean Delvare <khali@linux-fr.org> wrote:
> da903x_remove_subdevs() can be called in case of device initialization
> error, so it shouldn't be tagged __devexit.
>
Good catch.
Acked-by: Eric Miao <eric.miao@marvell.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-15 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-15 10:28 [PATCH] da903x: Fix section mismatch Jean Delvare
2008-12-15 10:45 ` Eric Miao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.