All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org, hjk@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq)
Date: Tue, 16 Dec 2008 09:16:46 -0800	[thread overview]
Message-ID: <20081216171646.GA12812@suse.de> (raw)
In-Reply-To: <20081216122731.GC3275@pengutronix.de>

On Tue, Dec 16, 2008 at 01:27:32PM +0100, Wolfram Sang wrote:
> > > +/* ---------------------------------------------------------------------
> > > + * OF bus binding
> > > + */
> > > +
> > > +#if defined(CONFIG_OF)
> > 
> > Same goes here, don't put #if in .c files please.
> 
> So, generally speaking, this means that I should not put a
> platform_driver and an of_platform_driver into one source file, but
> rather create an of_$DRIVER.c then?

Yes, this is the preferred way to do it.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: hjk@linutronix.de, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq)
Date: Tue, 16 Dec 2008 09:16:46 -0800	[thread overview]
Message-ID: <20081216171646.GA12812@suse.de> (raw)
In-Reply-To: <20081216122731.GC3275@pengutronix.de>

On Tue, Dec 16, 2008 at 01:27:32PM +0100, Wolfram Sang wrote:
> > > +/* ---------------------------------------------------------------------
> > > + * OF bus binding
> > > + */
> > > +
> > > +#if defined(CONFIG_OF)
> > 
> > Same goes here, don't put #if in .c files please.
> 
> So, generally speaking, this means that I should not put a
> platform_driver and an of_platform_driver into one source file, but
> rather create an of_$DRIVER.c then?

Yes, this is the preferred way to do it.

thanks,

greg k-h

  reply	other threads:[~2008-12-16 17:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 15:05 [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq Wolfram Sang
2008-12-11 15:05 ` Wolfram Sang
2008-12-11 20:50 ` Greg KH
2008-12-11 20:50   ` Greg KH
2008-12-16 12:27   ` adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq) Wolfram Sang
2008-12-16 12:27     ` Wolfram Sang
2008-12-16 17:16     ` Greg KH [this message]
2008-12-16 17:16       ` Greg KH
2008-12-16 12:25 ` [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq Paul Mundt
2008-12-16 12:25   ` Paul Mundt
2008-12-16 12:41   ` Wolfram Sang
2008-12-16 12:41     ` Wolfram Sang
2008-12-16 13:18     ` Paul Mundt
2008-12-16 13:18       ` Paul Mundt
2008-12-19 13:41     ` Magnus Damm
2008-12-19 13:41       ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081216171646.GA12812@suse.de \
    --to=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.